-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Psuedo targets are added to the "Select Debug Console" dropdown when an attached JS target is restarted #173993
Comments
I noticed this, I haven't looked into it at all but wondering whether it's related somehow to #169074 @connor4312 |
ignore my last comment... I found the setting Debug › Console: Close On End was 'off' by default. Turning it on resolved the problem |
Yea this looks expected since we have a process ID as part of the session name, so they get unique terminals. Could argue we shouldn't... but we do, and I've found it handy on more than one occasion |
@connor4312 @jpike88 The problem persists after turning on Debug › Console: Close On End (on version 1.75.1). When the said option is on, the terminal/console pane indeed closes when debug stops, but when I restart the process, the pane re-shows with the "select debug console" dropdown populated with the terminated processes. In any case, the problem surfaced in 1.75.0 so I still think there's a bug (or undocumented fix) that contributes to this issue. May I suggest to re-open the issue? |
@connor4312 @roblourens following up - this is still an issue and there's no fix nor a workaround. Can you please re-open the issue so that someone can give it a second look? |
Yep, thanks for the ping. This was hanging out in my notification queue but forgot to reopen it |
Previously the `Binder` was a little messy. The binder managed the "tree" of debug sessions, but teardown was not handled in a particular order. So, for example, when terminating a Node.js session with a bunch of child processes, the parent process could be terminated and disconnected while its children were nominally still "running" if their async shutdown logic didn't finish yet. Now that things are nicely ordered, I can fix microsoft/vscode#173993
If a child session is shut down or shutting down, don't detach it from its parent. Fixes #173993 Requires microsoft/vscode-js-debug#1619 to work reliably
If a child session is shut down or shutting down, don't detach it from its parent. Fixes #173993 Requires microsoft/vscode-js-debug#1619 to work reliably
If a child session is shut down or shutting down, don't detach it from its parent. Fixes microsoft#173993 Requires microsoft/vscode-js-debug#1619 to work reliably
Does this issue occur when all extensions are disabled?: Yes
I'm using VS Code to debug an attached Node app. The problem is that each time that I restart the Node app, new pseudo targets are added to the "Select Debug Console" dropdown of the debug console.
Problem started in 1.75.0. In prior versions, only the "Server" target would appear after restarts (I'm debugging in multiple target environment, so the dropdown is always visible). Since 1.75.0 (and .1), two new targets are added to this list (webpack + server.bundle.js) after each restart. Here's how this dropdown looks like after 3 restarts:
A similar issue happens when attempting to debug a React app - each reattach adds a new pseudo target to the list.
The targets that are added to the debug dropdown are "stale" - switching to one of these pseudo items shows an empty debug console.
Steps to Reproduce:
I tested the same configuration with VSCode 1.74.3, and the problem does not appear.
The text was updated successfully, but these errors were encountered: