refactor: improve and order handling in the Binder
#1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `Binder` was a little messy. The binder managed the "tree" of debug sessions, but teardown was not handled in a particular order. So, for example, when terminating a Node.js session with a bunch of child processes, the parent process could be terminated and disconnected while its children were nominally still "running" if their async shutdown logic didn't finish yet. Now that things are nicely ordered, I can fix microsoft/vscode#173993
connor4312
added a commit
to microsoft/vscode
that referenced
this pull request
Mar 29, 2023
If a child session is shut down or shutting down, don't detach it from its parent. Fixes #173993 Requires microsoft/vscode-js-debug#1619 to work reliably
rzhao271
approved these changes
Mar 29, 2023
connor4312
added a commit
to microsoft/vscode
that referenced
this pull request
Mar 29, 2023
If a child session is shut down or shutting down, don't detach it from its parent. Fixes #173993 Requires microsoft/vscode-js-debug#1619 to work reliably
trbot86
pushed a commit
to trbot86/vscode
that referenced
this pull request
Mar 29, 2023
If a child session is shut down or shutting down, don't detach it from its parent. Fixes microsoft#173993 Requires microsoft/vscode-js-debug#1619 to work reliably
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
Binderwas a little messy. The binder managed the "tree" of debug sessions, but teardown was not handled in a particular order. So, for example, when terminating a Node.js session with a bunch of child processes, the parent process could be terminated and disconnected while its children were nominally still "running" if their async shutdown logic didn't finish yet.Now that things are nicely ordered, I can fix this one microsoft/vscode#173993