Add settings editor search funnel button #147260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix modified action to act as a toggle - Make some actions toggle suggestions
rzhao271
force-pushed
the
rzhao271/settings-editor-search-funnel
branch
from
6d7995f
to
1ed33eb
Compare
roblourens
reviewed
Apr 12, 2022
roblourens
reviewed
Apr 12, 2022
roblourens
approved these changes
Apr 12, 2022
|
Addressed the comments above in #147461 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145710
This PR adds a funnel button to the right of the Settings editor search bar, so that users can click around to add tags, rather than manually type in tags. When users click on the funnel button, a dropdown of filter types appears.
For most filter types in the dropdown, clicking on it adds the appropriate tag to the search widget query, and refocuses the search widget.
For some filter types, clicking on it adds the appropriate tag to the search widget query, refocuses the search widget, but also pops open the suggestions. This behaviour occurs when there are pre-filled suggestions available, such as for the language and feature tags.
For the modified filter type, clicking on it adds the modified tag to the search widget query if it doesn't already exist. Otherwise, it removes that tag from the search widget query. The modified filter type option also displays with a checkmark whenever the modified tag appears in the search widget query.