Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language filter not discoverable, needs funnel icon inline action #145710

Closed
isidorn opened this issue Mar 22, 2022 · 1 comment · Fixed by #147260
Closed

Language filter not discoverable, needs funnel icon inline action #145710

isidorn opened this issue Mar 22, 2022 · 1 comment · Fixed by #147260
Assignees
@rzhao271 @lychung7
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues
Milestone
April 2022

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 22, 2022 •
edited
Loading

Testing #145588

I liked some of the mocks that @lychung7 did, to use the inline action in the search box to make the language filter more discoverable.
With the current approach no user will find this feature.

I apologise if this is already planned for next milestone and if this issue is just duplication.

fyi @sandy081
@isidorn isidorn added the settings-editor VS Code settings editor issues label Mar 22, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Mar 22, 2022 •
edited
Loading

This feature is planned but I don't think I made an issue for it yet, so we can use this one to track.

@rzhao271 rzhao271 added this to the April 2022 milestone Mar 22, 2022
@rzhao271 rzhao271 added the feature-request Request for new features or functionality label Mar 22, 2022
@rzhao271 rzhao271 changed the title Language filter not discoverable Language filter not discoverable, needs funnel icon inline action Mar 22, 2022
@kieferrm kieferrm mentioned this issue Apr 3, 2022
Closed
@rzhao271 rzhao271 mentioned this issue Apr 11, 2022
Merged
rzhao271 added a commit that referenced this issue Apr 13, 2022
@rzhao271
Add settings editor search funnel button (#147260)
214ff3b 
Ref #145710
@rzhao271 rzhao271 mentioned this issue Apr 14, 2022
Merged
This was referenced Apr 22, 2022
Closed
Merged
@kieferrm kieferrm mentioned this issue Apr 26, 2022
Closed
15 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

@lychung7 lychung7

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues
Projects
None yet
Milestone
April 2022
Development

Successfully merging a pull request may close this issue.

Add settings editor search funnel button microsoft/vscode
4 participants
@isidorn @rzhao271 @lychung7 and others