Removing charset_flag setting on windows #6673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem with not specifying any flags is that the charset becomes dependent on the host system -- and most sources do not pass a flag. Therefore, it is probably best for us to always pass /utf-8 except in the one or two cases where the source is incompatible. I'm not sure what the optimal way to do this is. |
|
Fix merged in #7074 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing CHARSET_FLAG setting on windows:
PR #5924 removed '/utf-8' since the compiler options are incompatible. We think the charset_flag should be added by the source itself, not vcpkg.
Known affect:
pango and gtk failed on Non-English environment, PR #6671 has fixed it.