Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix 2 issues when upgrade thrift:
Issue 1: Failed with cl : Command line error D8016 : '/utf-8' and '/source-charset:utf-8' command-line options are incompatible
Fix: The thrift latest changes added ‘/source-charset:utf-8' and ‘/execution-charset:utf-8’ by commit ‘a6a3a78’. And VCPKG added options ‘/utf-8' in .\scripts\toolchains\windows.cmake.
So the fix should remove the one of the options, I removed ‘/utf-8' in .\scripts\toolchains\windows.cmake, I think VCPKG doesn't need add /utf-8 to the pkg, it should added by the pkg itself.
Issue 2: Failed when performing post-build validation
Fix: Add ‘vcpkg_fixup_cmake_targets(CONFIG_PATH "lib/cmake/thrift")’ in thrift portfile to help copy the cmake targets to install directory.