Reduce CursorChanged Events for Accessibility #5196
Conversation
| @@ -246,7 +255,6 @@ UiaEngine::UiaEngine(IUiaEventDispatcher* dispatcher) : | |||
| _selectionChanged = false; | |||
| _textBufferChanged = false; | |||
| _cursorChanged = false; | |||
| _prevSelection.clear(); | |||
There was a problem hiding this comment.
wots all this then eh
There was a problem hiding this comment.
Well, I realized, why should we clear the previousSelection between frames? If it's clear when we render a new frame, we'll always have the selection be "new". So, this should reduce the number of times we send a selection event too.
|
It seems that Azure CI doesn't provide artefacts for PRs. Could you please upload (or point me at) a build for testing? |
Your best bet would be that you have to build the branch yourself. I tried uploading a ZIP of the package but GitHub said it was too large. I'm merging this change into master now, though, so let us know if you encounter any issues. |
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
Working great with NVDA, thanks! As an aside, it doesn't look like the .msix packages from Azure are installable. Renaming to .zip and extracting allows me to run the terminal/console, but just opening the package gives me an error that the package isn't signed. Is there any way to disable the signature check? Developer mode is enabled on my machine. |
|
Unfortunately, that's one of the huge pain points with this project on the development side. There's no way to turn off signature checking, even for locally-installed locally-produced packages 😦 Sometimes it's just easier to extract the msix like a zip file and run WindowsTerminal.exe out of it. We haven't broken that, and we do sorta try to make sure it doesn't break. 😄 |
|
Thanks again for testing. There's probably something we can do to make this more palatable. |
## Summary of the Pull Request Reduce the number of times we dispatch a cursor changed event. We were firing it every time the renderer had to do anything related to the cursor. Unfortunately, blinking the cursor triggered this behavior. Now we just check if the position has changed. ## PR Checklist * [X] Closes #5143 ## Validation Steps Performed Verified using Narrator Also verified #3791 still works right
Improve wide glyph support in UIA (GH-4946) Add enhanced key support for ConPty (GH-5021) Set DxRenderer non-text alias mode (GH-5149) Reduce CursorChanged Events for Accessibility (GH-5196) Add more object ID tracing for Accessibility (GH-5215) Add SS3 cursor key encoding to ConPty (GH-5383) UIA: Prevent crash from invalid UTR endpoint comparison (GH-5399) Make CodepointWidthDetector::GetWidth faster (CC-3727) add til::math, use it for float conversions to point, size (GH-5150) Add support for renderer backoff, don't FAIL_FAST on 3x failures, add UI (GH-5353) Fix a deadlock and a bounding rects issue in UIA (GH-5385) Don't duplicate spaces from potentially-wrapped EOL-deferred lines (GH-5398) Reimplement the VT tab stop functionality (CC-5173) Clamp parameter values to a maximum of 32767. (CC-5200) Prevent the cursor type being reset when changing the visibility (CC-5251) Make RIS switch back to the main buffer (CC-5248) Add support for the DSR-OS operating status report (CC-5300) Update the virtual bottom location if the cursor moves below it (CC-5317) ci: run spell check in CI, fix remaining issues (CC-4799) (CC-5352) Set Cascadia Code as default font (GH-5121) Show a double width cursor for double width characters (GH-5319) Delegate all character input to the character event handler (CC-4192) Update til::bitmap to use dynamic_bitset<> + libpopcnt (GH-5092) Merged PR 4465022: [Git2Git] Merged PR 4464559: Console: Ingest OSS changes up to e055079 Correct scrolling invalidation region for tmux in pty w/ bitmap (GH-5122) Render row-by-row instead of invalidating entire screen (GH-5185) Make conechokey use ReadConsoleInputW by default (GH-5148) Manually pass mouse wheel messages to TermControls (GH-5131) This fixes C-M-space for WSL but not for Win32, but I'm not sure there's a problem in Win32 quite yet. (GH-5208) Fix copying wrapped lines by implementing better scrolling (GH-5181) Emit lines wrapped due to spaces at the end correctly (GH-5294) Remove unneeded whitespace (CC-5162)
|
🎉 Handy links: |
ghost
mentioned this pull request
Summary of the Pull Request
Reduce the number of times we dispatch a cursor changed event. We were firing it every time the renderer had to do anything related to the cursor. Unfortunately, blinking the cursor triggered this behavior. Now we just check if the position has changed.
PR Checklist
Validation Steps Performed
Verified using Narrator
Also verified #3791 still works right