Reduce CursorChanged Events for Accessibility

microsoft · Mar 30, 2020 · 8403a76 · 8403a76
1 parent ca6b54e
commit 8403a76
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/src/cascadia/TerminalControl/TermControl.cpp b/src/cascadia/TerminalControl/TermControl.cpp
@@ -1817,6 +1817,11 @@ namespace winrt::Microsoft::Terminal::TerminalControl::implementation
             if (!_closing.load())
             {
                 TSFInputControl().TryRedrawCanvas();
+
+                if (_uiaEngine.get())
+                {
+                    _uiaEngine->CursorPositionChanged();
+                }
             }
         }
     }

diff --git a/src/renderer/uia/UiaRenderer.cpp b/src/renderer/uia/UiaRenderer.cpp
@@ -71,7 +71,6 @@ UiaEngine::UiaEngine(IUiaEventDispatcher* dispatcher) :
 // - S_FALSE
 [[nodiscard]] HRESULT UiaEngine::InvalidateCursor(const COORD* const /*pcoordCursor*/) noexcept
 {
-    _cursorChanged = true;
     return S_FALSE;
 }
 
@@ -454,6 +453,11 @@ UiaEngine::UiaEngine(IUiaEventDispatcher* dispatcher) :
     return S_FALSE;
 }
 
+void UiaEngine::CursorPositionChanged() noexcept
+{
+    _cursorChanged = true;
+}
+
 // Method Description:
 // - Updates the window's title string.
 // - Currently unused by this renderer.

diff --git a/src/renderer/uia/UiaRenderer.hpp b/src/renderer/uia/UiaRenderer.hpp
@@ -75,6 +75,7 @@ namespace Microsoft::Console::Render
         [[nodiscard]] HRESULT GetFontSize(_Out_ COORD* const pFontSize) noexcept override;
         [[nodiscard]] HRESULT IsGlyphWideByFont(const std::wstring_view glyph, _Out_ bool* const pResult) noexcept override;
 
+        void CursorPositionChanged() noexcept;
     protected:
         [[nodiscard]] HRESULT _DoUpdateTitle(const std::wstring& newTitle) noexcept override;