Update the dragbar when the titlebar content size changes #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
Area-User Interface
carlos-zamora
approved these changes
Mar 9, 2020
DHowett-MSFT
approved these changes
Mar 9, 2020
carlos-zamora
pushed a commit
that referenced
this pull request
Mar 9, 2020
## Summary of the Pull Request Add a `SizeChanged` handler to the titlebar content UI element. It's possible that this element's size will change after the dragbar's. When that happens, the drag bar won't send another `SizeChanged` event, because the dragbar's _size_ didn't change, only it's position. ## References We originally duped this issue to #4166, but after #4829 fixed that issue, this one persisted. They're all related, and _look_ like dupes, but they weren't. ## PR Checklist * [x] Closes #4288 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed I had a solid 100% repro that doesn't repro anymore. I've maximized, restored, resized, and generally played with the window a bunch.
carlos-zamora
pushed a commit
that referenced
this pull request
Mar 10, 2020
## Summary of the Pull Request Add a `SizeChanged` handler to the titlebar content UI element. It's possible that this element's size will change after the dragbar's. When that happens, the drag bar won't send another `SizeChanged` event, because the dragbar's _size_ didn't change, only it's position. ## References We originally duped this issue to #4166, but after #4829 fixed that issue, this one persisted. They're all related, and _look_ like dupes, but they weren't. ## PR Checklist * [x] Closes #4288 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed I had a solid 100% repro that doesn't repro anymore. I've maximized, restored, resized, and generally played with the window a bunch.
carlos-zamora
added a commit
that referenced
this pull request
Mar 10, 2020
)" This reverts commit 62e424f.
carlos-zamora
pushed a commit
that referenced
this pull request
Mar 10, 2020
## Summary of the Pull Request Add a `SizeChanged` handler to the titlebar content UI element. It's possible that this element's size will change after the dragbar's. When that happens, the drag bar won't send another `SizeChanged` event, because the dragbar's _size_ didn't change, only it's position. ## References We originally duped this issue to #4166, but after #4829 fixed that issue, this one persisted. They're all related, and _look_ like dupes, but they weren't. ## PR Checklist * [x] Closes #4288 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed I had a solid 100% repro that doesn't repro anymore. I've maximized, restored, resized, and generally played with the window a bunch.
carlos-zamora
added a commit
that referenced
this pull request
Mar 10, 2020
)" This reverts commit 62e424f.
carlos-zamora
added a commit
that referenced
this pull request
Mar 11, 2020
)" This reverts commit 62e424f.
carlos-zamora
added a commit
that referenced
this pull request
Mar 12, 2020
)" This reverts commit 62e424f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add a
SizeChangedhandler to the titlebar content UI element. It's possible that this element's size will change after the dragbar's. When that happens, the drag bar won't send anotherSizeChangedevent, because the dragbar's size didn't change, only it's position.References
We originally duped this issue to #4166, but after #4829 fixed that issue, this one persisted. They're all related, and look like dupes, but they weren't.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
I had a solid 100% repro that doesn't repro anymore.
I've maximized, restored, resized, and generally played with the window a bunch.