Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fullscreen from maximized still doesn't work properly; title bar issue? cutout region issue? #4224

Closed
0xcaffebabe opened this issue Jan 15, 2020 · 4 comments · Fixed by #4904
Closed

fullscreen from maximized still doesn't work properly; title bar issue? cutout region issue? #4224

0xcaffebabe opened this issue Jan 15, 2020 · 4 comments · Fixed by #4904
Assignees
@zadjii-msft
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@0xcaffebabe
Copy link

0xcaffebabe commented Jan 15, 2020 •
edited
Loading

Environment

Windows build number: Windows 10 1909 build 18363.535
Windows Terminal version (if applicable): 0.8.10091.0
shell:powershell

Steps to reproduce

1.launch windows terminal
2.maximize windows terminal
2.press ctrl+enter into fullscreen mode

Expected behavior

terminal should be a maximize state

Actual behavior

but title bar has error state in fullscreen
批注 2020-01-15 090830
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 15, 2020
@Tr4pSec
Copy link

Tr4pSec commented Jan 16, 2020 •
edited
Loading

Not seeing this issue in Windows 10 1909 build 18363.535 with Windows Terminal 0.8.10091.0

However I see this error in Windows 10 1903 build 18362.592 with Windows Terminal 0.8.10091.0

Edit: Terminals running same config

@DHowett-MSFT DHowett-MSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Jan 16, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 16, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Jan 16, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 16, 2020
@DHowett-MSFT DHowett-MSFT changed the title title bar has error state in fullscreen fullscreen from maximized still doesn't work properly; title bar issue? cutout region issue? Jan 16, 2020
This was referenced Jan 23, 2020
Closed
Closed
@JekRock JekRock mentioned this issue Feb 21, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Feb 26, 2020
Closed
@zadjii-msft
Copy link
Member

From @Nafana in #4725

Should have tested this sooner, sorry! This is only reproducible if you have the "Automatically hide the taskbar in desktop mode" set to enabled in Windows settings.

To access this setting:

  1. Right-click on your taskbar

  2. Click Taskbar Settings

@drk-mtr
Copy link

drk-mtr commented Feb 26, 2020

I'm just going to put the words full screen here in the hope that it helps people find this. I stupidly hadn't thought to search fullscreen, so I filled out an issue template before realising it's a dup.

@zadjii-msft zadjii-msft self-assigned this Mar 13, 2020
@zadjii-msft
Copy link
Member

zadjii-msft commented Mar 13, 2020 •
edited
Loading

Hey so we've made a couple changes in this area (#4857, #4845), and no one on the team is seeing this anymore. We're thinking that this was fixed by a combo of those two PRs. If this actually isn't fixed in 0.10 (whenever that gets released), then feel free to post here and we'll re-open this one.

Thanks all!

EDIT: Nevermind that, I'm just daft and didn't turn on the "hide taskbar" setting. This is still a real bug.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Mar 13, 2020
@zadjii-msft zadjii-msft reopened this Mar 13, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 13, 2020
@zadjii-msft zadjii-msft mentioned this issue Mar 13, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Mar 13, 2020
@ghost ghost closed this as completed in #4904 Mar 13, 2020
ghost pushed a commit that referenced this issue Mar 13, 2020
@zadjii-msft
Always remove the drag bar when entering fullscreen (#4904)
5a1b7b6 
## Summary of the Pull Request

  When the auto-hide taskbar setting is enabled, then we don't
  always get another window message to trigger us to remove the drag bar.
  So, make sure to update the size of the drag region here, so that it
  _definitely_ goes away.

## References

## PR Checklist
* [x] Closes #4224
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Validation Steps Performed

Manually tested it
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 13, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Always remove the drag bar when entering fullscreen microsoft/terminal
6 participants
@DHowett-MSFT @zadjii-msft @Tr4pSec @0xcaffebabe @drk-mtr @cinnamon-msft