-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run the tests as a separate build stage #12141
Conversation
woah, that looks like it works. Thats so cool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thank goodness. This is exactly what I wanted.
The way we're shuttling all exe/dll/etc artifacts from build to build scares me a little and we might want to use pipeline artifacts instead (docs say they're faster!), but... if you guys are cool with it I can be cool with it too |
If it works, I'm cool with it
|
I honestly had no idea there were two different types of artifacts. So that should be a follow on investigation, IMO. |
I'm going to run the non-CI version against this to make sure Helix can still submit/report. |
yes, this works in helix. the tests fail, but submission works. I should move helix submission to another sub-job |
This commit moves the unit and feature tests to a separate stage, which can be retried more easily.
Closes #11858