Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run the tests as a separate build stage #12141

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Jan 11, 2022

This commit moves the unit and feature tests to a separate stage, which can be retried more easily.

Closes #11858

@zadjii-msft
Copy link
Member

woah, that looks like it works. Thats so cool

Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thank goodness. This is exactly what I wanted.

@DHowett
Copy link
Member Author

DHowett commented Jan 12, 2022

The way we're shuttling all exe/dll/etc artifacts from build to build scares me a little and we might want to use pipeline artifacts instead (docs say they're faster!), but... if you guys are cool with it I can be cool with it too

@zadjii-msft
Copy link
Member

If it works, I'm cool with it

implying I really understand our ci config

@miniksa
Copy link
Member

miniksa commented Jan 12, 2022

The way we're shuttling all exe/dll/etc artifacts from build to build scares me a little and we might want to use pipeline artifacts instead (docs say they're faster!), but... if you guys are cool with it I can be cool with it too

I honestly had no idea there were two different types of artifacts. So that should be a follow on investigation, IMO.

@DHowett DHowett changed the title WIP: what if we run the tests as a separate thing ci: run the tests as a separate build stage Jan 12, 2022
@DHowett DHowett marked this pull request as ready for review January 12, 2022 21:27
@DHowett
Copy link
Member Author

DHowett commented Jan 12, 2022

I'm going to run the non-CI version against this to make sure Helix can still submit/report.

@ghost ghost added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products. labels Jan 12, 2022
@DHowett
Copy link
Member Author

DHowett commented Jan 12, 2022

yes, this works in helix. the tests fail, but submission works.

I should move helix submission to another sub-job

@DHowett DHowett merged commit 1a62f47 into main Jan 12, 2022
@DHowett DHowett deleted the dev/duhowett/yote_tes branch January 12, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put the x64 feature tests in a separate build phase that downloads the x64 build artifacts
3 participants