Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put the x64 feature tests in a separate build phase that downloads the x64 build artifacts #11858

Closed
miniksa opened this issue Dec 1, 2021 · 3 comments · Fixed by #12141
Closed

Put the x64 feature tests in a separate build phase that downloads the x64 build artifacts #11858

miniksa opened this issue Dec 1, 2021 · 3 comments · Fixed by #12141
Assignees
@miniksa
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Engineering Impro...

Comments

@miniksa
Copy link
Member

miniksa commented Dec 1, 2021

It's driving me nuts that the machine sometimes goes LOL no and goes away on a rerun. Let's not waste time with all the other compile phases and such.
@miniksa miniksa added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Meta The product is the management of the products. Issue-Task It's a feature request, but it doesn't really need a major design. labels Dec 1, 2021
@miniksa miniksa added this to the Engineering Improvements 2021 milestone Dec 1, 2021
@miniksa miniksa self-assigned this Dec 1, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 1, 2021
@zadjii-msft
Copy link
Member

This is a good enough solution to #11289

@miniksa
Copy link
Member Author

miniksa commented Dec 1, 2021

This is a good enough solution to #11289

If I can make it work... sorry I didn't see that one.

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 2, 2021
@DHowett
Copy link
Member

DHowett commented Jan 11, 2022

I'm testing this in #12141

@DHowett DHowett mentioned this issue Jan 12, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Jan 12, 2022
DHowett added a commit that referenced this issue Jan 12, 2022
@DHowett
ci: run the tests as a separate build stage (#12141)
1a62f47 
This commit moves the unit and feature tests to a separate stage, which can be retried more easily.

Closes #11858
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 12, 2022
@zadjii-msft zadjii-msft mentioned this issue Jan 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miniksa miniksa

Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Meta The product is the management of the products. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Engineering Improvements
Development

Successfully merging a pull request may close this issue.

ci: run the tests as a separate build stage microsoft/terminal
3 participants
@DHowett @miniksa @zadjii-msft