Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish code for actions page #10173

Merged
1 commit merged into from
Jun 3, 2021
Merged

Polish code for actions page #10173

1 commit merged into from
Jun 3, 2021

Conversation

carlos-zamora
Copy link
Member

Applies feedback from #9949 (review)

Highlights include:

  • bugfix: make all edit buttons stay visible if the user is using assistive technology
  • rename a few functions and resources to match the correct naming scheme
  • update the localized text for a conflicting key chord being assigned
  • provide better comments throughout the actions page code

References

#9949 - Original PR
Closes #10168

@ghost ghost added Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels May 24, 2021
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Jun 2, 2021
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jun 3, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit c9dc419 into main Jun 3, 2021
@ghost ghost deleted the dev/cazamor/actions-page/follow-up branch June 3, 2021 22:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@leonMSFT leonMSFT leonMSFT approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

@miniksa miniksa Awaiting requested review from miniksa

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply leftover PR feedback to Actions Page
3 participants
@carlos-zamora @DHowett @leonMSFT