Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply leftover PR feedback to Actions Page #10168

Closed
carlos-zamora opened this issue May 24, 2021 · 0 comments · Fixed by #10173
Closed

Apply leftover PR feedback to Actions Page #10168

carlos-zamora opened this issue May 24, 2021 · 0 comments · Fixed by #10173
Assignees
@carlos-zamora
Labels
Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.10

Comments

@carlos-zamora
Copy link
Member

There was still a bit of polish leftover for #9949 that I didn't get around to.

This task tracks fixing those leftover PR comments: #9949 (review)
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Settings UI Anything specific to the SUI labels May 24, 2021
@carlos-zamora carlos-zamora added this to the Terminal v1.9 milestone May 24, 2021
@carlos-zamora carlos-zamora self-assigned this May 24, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 24, 2021
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 24, 2021
@carlos-zamora carlos-zamora mentioned this issue May 24, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label May 24, 2021
@ghost ghost closed this as completed in #10173 Jun 3, 2021
ghost pushed a commit that referenced this issue Jun 3, 2021
@carlos-zamora
Polish code for actions page (#10173)
c9dc419 
Applies feedback from #9949 (review)

Highlights include:
- bugfix: make all edit buttons stay visible if the user is using assistive technology
- rename a few functions and resources to match the correct naming scheme
- update the localized text for a conflicting key chord being assigned
- provide better comments throughout the actions page code

## References
#9949 - Original PR
Closes #10168
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jun 3, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.10
Development

Successfully merging a pull request may close this issue.

Polish code for actions page microsoft/terminal
2 participants
@carlos-zamora @cinnamon-msft