Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't scroll or drag files over some areas with non 100% scaling #2606

Closed
dsafa opened this issue Aug 29, 2019 · 6 comments
Closed

Can't scroll or drag files over some areas with non 100% scaling #2606

dsafa opened this issue Aug 29, 2019 · 6 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Milestone
Backlog

Comments

@dsafa
Copy link
Contributor

dsafa commented Aug 29, 2019

Environment

Windows build number: 10.0.18362.0
Windows Terminal version (if applicable): built from master @ f4294b1

Any other software? N/A

Steps to reproduce

  1. Turn off the Windows setting scroll inactive window when I hover over them
  2. Have terminal on monitor with scaling other than 100%
  3. Have enough text to scroll
  4. Focus terminal and scroll with mouse wheel

Expected behavior

Terminal should scroll

Actual behavior

Scrolling behavior is different depending on the mouse position. In some areas, it scrolls properly. In other regions, scrolling won't work.

  • If scaling is 100%, then scrolling works properly. If scroll inactive window setting is on, then scrolling works properly.
  • Same issue for both normal and non client window

scroll-region

Heres what I think is happening:

With scroll inactive window off, the wm_mousewheel messages are only be sent to current focused window (If i've read the docs correctly).
I think that the window that takes focus is not scaled properly so in some areas the mouse is 'outside' and won't receive the mouse wheel messages (maybe it needs to be focused and hovered?).
Terminal does have a couple windows (the host and the xaml island ones) but i'm not sure which one takes focus when terminal is active. I tried checking for wm_mousewheel in the window procs but I could not see the message being sent.
I have my suspicions that it's the top level window that is supposed to be receiving the messages because using Spy++, when I highlighted the top level window, its size also matched the area where scrolling works. But visually, everything seems to be scaled properly so I'm not too sure now.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 29, 2019
@zadjii-msft
Copy link
Member

@Austin-Lamb & @ocalvo might be interested in this

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Aug 29, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 29, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Aug 29, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 29, 2019
@DHowett-MSFT
Copy link
Contributor

I just want to say we all really appreciate how robust this bug report is and how well you've investigated it.
Thanks!

@zadjii-msft zadjii-msft added the Priority-3 A description (P3) label Jan 22, 2020
@jingyu9575 jingyu9575 mentioned this issue Feb 13, 2020
Closed
@DHowett-MSFT DHowett-MSFT changed the title Can't scroll in some areas with non 100% scaling and 'scroll inactive windows' off Can't scroll or drag files over some areas with non 100% scaling Feb 14, 2020
@zadjii-msft zadjii-msft mentioned this issue Feb 20, 2020
Closed
@zadjii-msft
Copy link
Member

zadjii-msft commented Mar 11, 2020 •
edited
Loading

Oh no, this is likely a platform bug. We've got a discussion with some folks on the XAML team to help investigate this, but I think this isn't going to make the 1.0 cut.

This issue is now tracking the internal bugs MSFT:25518888 and MSFT:23625486, and the external microsoft/microsoft-ui-xaml#2101

@zadjii-msft zadjii-msft added the Tracking-External This bug isn't resolved, but it's following an external workitem. label Mar 11, 2020
@zadjii-msft zadjii-msft self-assigned this Mar 11, 2020
@zadjii-msft zadjii-msft mentioned this issue Mar 12, 2020
Closed
This was referenced Mar 24, 2020
Closed
Merged
ghost pushed a commit that referenced this issue Apr 1, 2020
@zadjii-msft
Manually pass mouse wheel messages to TermControls (#5131)
a12a628 
## Summary of the Pull Request

As we've learned in #979, not all touchpads are created equal. Some of them have bad drivers that makes scrolling inactive windows not work. For whatever reason, these devices think the Terminal is all one giant inactive window, so we don't get the mouse wheel events through the XAML stack. We do however get the event as a `WM_MOUSEWHEEL` on those devices (a message we don't get on devices with normally functioning trackpads).

This PR attempts to take that `WM_MOUSEWHEEL` and manually dispatch it to the `TermControl`, so we can at least scroll the terminal content.

Unfortunately, this solution is not very general purpose. This only works to scroll controls that manually implement our own `IMouseWheelListener` interface. As we add more controls, we'll need to continue manually implementing this interface, until the underlying XAML Islands bug is fixed. **I don't love this**. I'd rather have a better solution, but it seems that we can't synthesize a more general-purpose `PointerWheeled` event that could get routed through the XAML tree as normal. 

## References

* #2606 and microsoft/microsoft-ui-xaml#2101 - these bugs are also tracking a similar "inactive windows" / "scaled mouse events" issue in XAML

## PR Checklist
* [x] Closes #979
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

I've also added a `til::point` conversion _to_ `winrt::Windows::Foundation::Point`, and some scaling operators for `point`

## Validation Steps Performed

* It works on my HP Spectre 2017 with a synaptics trackpad
  - I also made sure to test that `tmux` works in panes on this laptop
* It works on my slaptop, and DOESN'T follow this hack codepath on this machine.
@zadjii-msft zadjii-msft mentioned this issue Mar 2, 2021
Closed
@zadjii-msft zadjii-msft mentioned this issue Aug 3, 2021
Closed
@zadjii-msft
Copy link
Member

Also adding MSFT:35026617 to the list of internal tracking issues, since 23625486 was resolved, but didn't fix this.

@zadjii-msft zadjii-msft mentioned this issue Aug 19, 2021
Closed
@zadjii-msft zadjii-msft mentioned this issue Oct 20, 2021
Closed
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft zadjii-msft removed their assignment Jan 7, 2022
@zadjii-msft zadjii-msft mentioned this issue Apr 11, 2022
Closed
@zadjii-msft
Copy link
Member

Alrighty so MSFT:35026617 was fixed earlier this year, but unfortunately doesn't make the cut to service back to Windows 10. Alas 🤷. Anyways, this is fixed on the latest Windows 11 builds, so I'm gonna close this out, since there's nothing else for us to do here. Thanks!

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Apr 11, 2022
@zadjii-msft zadjii-msft mentioned this issue Apr 18, 2022
Closed
@malcolm-bell
Copy link

malcolm-bell commented Nov 16, 2023 •
edited
Loading

Still not working.
Windows Terminal
Version: 1.18.2822.0
Windows 11 22H2 OS build 22621.2428

Recording.2023-11-17.094703.mp4

@zadjii-msft zadjii-msft mentioned this issue Apr 3, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@DHowett @dsafa @DHowett-MSFT @zadjii-msft @cinnamon-msft @malcolm-bell