-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drag-Drop file not working with initial/default tab #4654
Comments
I can't reproduce this, even relaunching terminal 10 times. Is there anything else unusual about your environment? |
Nope.. I'm not even on any insider rings. I was dragging the same file each time. It was repeatable on my machine across restarts of terminal. It's not reproducing this morning. One change since last night: My default profile is Powershell Preview. When it was reproducing I was on preview 3. Since that time I updated to rc2 and juggled some profiles around while I looked at the generator support (nice, btw.. but could use some docs for the user). Perhaps that had an effect. |
@deoradh Any chance what you're seeing is actually #4567? That might explain why it seems so random. @DHowett-MSFT I'm considering pulling #2606 into 1.0 if that's the case. #4567 seems like a much easier/trivial way to hit that bug, and might be worth pulling forward. Thoughts? |
Oh! Great pull! |
@zadjii-msft -- It's uncertain. I can repro #2606/#4567, but I cannot state that this was the same. It is possible: My PS startup spews a bunch of text at the start, so I may have found myself dragging to the bottom of the window, where the cursor was, and so by chance never seeing what happens if I was in the upper portion of the pane. But it doesn't explain the impression that this was resolving for all subsequent tabs opened. But at this point, it looks like I can only give the impression. I can't repro it anymore except for the known bug. (Count this as a vote for pulling forward, anyway.) |
@deoradh thanks again -- I know we're not a hundred percent sure if it's the same bug, but for now I'm going to track them together. It seems like we the platform (not the Terminal, unfortunately) may have a hit-testing issue in general. Closing this one in favor of talking about it in #2606. Since 2606 may require changes to Windows, it might not make it for 1.0 -- we're only as agile as our slowest component 😄 |
Environment
Steps to reproduce
Expected behavior
"Copy as path" works for all tabs, including the default
Actual behavior
"Copy as path" appears to not work for the initial, default tab. This does not appear to be a matter of the invoked host (eg, cmd vs PS Core), but behaves like the default tab is simply not registered as a drop target.
The text was updated successfully, but these errors were encountered: