Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick 0.68 fixes for rn-tester publishing #1256

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Cherry pick 0.68 fixes for rn-tester publishing #1256

merged 3 commits into from
Jul 12, 2022

Conversation

rasaha91
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Cherry-picking several changes performed on the 0.68-stable branch related to publishing rn-tester as an artifact.

Changelog

[Android] [Internal] - Cherry-pick rn-tester publishing related changes to main

Test Plan

PR builds successfully.

@rasaha91
Merge pull request microsoft#1250 from rasaha91/add-rntester-to-artif…
fb8740b 
…acts

Publish rn-tester apks and bundle to build artifacts
@rasaha91
Merge pull request microsoft#1254 from rasaha91/fix-incorrect-feed
9c91703 
Use the Office feed for the publish pipeline
@rasaha91
Merge pull request microsoft#1255 from rasaha91/fix-missing-requests
3d8691c 
Fix missing requests python package
@rasaha91 rasaha91 requested review from a team as code owners July 12, 2022 20:12
@rasaha91 rasaha91 enabled auto-merge July 12, 2022 20:12
@rasaha91 rasaha91 merged commit 1498fe5 into microsoft:main Jul 12, 2022
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 25, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
9d46fd7 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 6a3c872bd5f17c67119849f98e83a399ceb8f5a9
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 25, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
b841ca2 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 4a766025e85f8da28006864e624e60bbe377a5c0
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 25, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
360d8ca 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: d0721f8150891ed541bd2fe06f1c0ce17adda100
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 25, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
3b0558d 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 869cafce77517f07b8e4d6a5eddc50fcc1418203
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 25, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
66b842f 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 13da0d1251d5b9ccd01c0723dc122d051cf29d18
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 25, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
0986706 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 27552632fbadc5ebf7f8b731b1c1cf98ed9f472d
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
20a7985 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 2eb713fca08254ebb93ddb0c873e564503f56327
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
a576e7c 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 58dbc9bed760d477458092de4e240ca123806bbf
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
96d11ed 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: bd2502ad4adebaeb79b01075f68a364af4b82301
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
2fd7c3a 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: eb3f00c9827815134927886a26eb26a0c3598727
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
4d4bb72 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 547fe89b47438cdc3bbf6e70b44b375f3e488af0
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
2740560 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 0caa4177278f3d14117768db99faff9ef57f8a4a
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
87a7d39 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 37938bb920e60f959c0ca673e8b6abf768dadb6b
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
96dbc1e 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 9655d2d816f7ab4e24eef7302d6bfc16788f6c8d
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
f30d213 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: c999a63a9dd46b2eeace96481d9fe1577c774141
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
8c44f46 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 5f2e54166d19d27954467509d4eeb2121b6fa5dd
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
18b581d 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 5c097155732199827758517a931106daa1e22783
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
fa5dfee 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 7232a831dd67659510f3afea943d5d322935ce0a
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
17e06c5 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: bd04c707cf4ffdeae344ba5a477dda64bca84f32
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
81a2c91 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: f3f05dc13b002560fcb0b07212b4bea5543fddb1
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
69df8b0 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 6c342de6976f7018fdfcc647fde1c62787d1e7c5
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
04d16f5 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: b0ff789b3bdcd34ae2cb139ab3cdb3101455f2ce
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
202fb17 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 193f10dbcd2a3ec670112002b5955570855e8a6f
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
601279c 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: c6de46fe67f0913ba97625e41641d73c90404d6d
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
767ef8d 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 86237ba0d808867f90de611c903f8468c5586f74
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
cc045d6 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 0463c21a632160d6875a9ff50868807cb3736e7b
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 26, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
5841678 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 6e1ce40fe0d85b1856864cd481c98f251f82d3be
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
d87ec80 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 79d274e86ff60ea7794fa310367335fa4c2accaf
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
7b1db65 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: c5e493f65fb1ac39ff5986c2b6d945f95c06ee94
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
0182360 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 8c9966ffcfc07d75a93818ded0a2f11e5f0ee19c
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
9e19964 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 243ec7350c199c969332d608303d6af4ac16416d
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
1e61e60 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: ea0660479e9557ceda064c3e6fcc5f535daa7cbb
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
764d3f9 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 2d1cb3d046d3aa0a5e1bc540251cf90bcf602a5e
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
e34ab95 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 86aa19509f1850fa2254495cd52080683a717d35
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
efb267c 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 15db2a6f99359d320ddb9c6d21880cb9715cf6dc
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
a0740e6 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 4c013a5d9492371404e0956a8fe836ec6ea9e1ba
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
dea10d0 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 91faea8356d2ac1758ed6e23b05c45aef366debd
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
f3efa08 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 462641b3d7554d617a8bb0f08febe9d033578386
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
5be8917 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: af5881c57b634399e0cb650150072149779bbf9f
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
00085f6 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: 599e99faa5399361431e131c7453f197ee8457ff
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Apr 27, 2023
@NickGerleman @facebook-github-bot
Add YGErrata Enum (microsoft#1256)
c7dcb42 
Summary:
X-link: facebook/yoga#1256

Pull Request resolved: facebook#37076

This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247.

It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as:
1. Implement errata API
2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`)
3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation.

I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).

Reviewed By: rshest

Differential Revision: D45254098

fbshipit-source-id: d4b61271a8018f548f2d9d8c953db4b121a502d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mganandraj mganandraj mganandraj approved these changes

@Saadnajmi Saadnajmi Saadnajmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rasaha91 @mganandraj @Saadnajmi