Add YGErrata Enum #1256
Closed
Add YGErrata Enum #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 5736fe13337e737f0c0ffa59349520f7eedd5fd1
NickGerleman
force-pushed
the
export-D45254098
branch
from
f277581
to
2098db3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 25, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 6a3c872bd5f17c67119849f98e83a399ceb8f5a9
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 366f7d7413150b8dccabb7f7b62be21e5b2dfd31
NickGerleman
force-pushed
the
export-D45254098
branch
from
2098db3
to
655dd6a
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 25, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 4a766025e85f8da28006864e624e60bbe377a5c0
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 1bc37dfb464dfe0c6eba366e3dabbf62bc4e2315
NickGerleman
force-pushed
the
export-D45254098
branch
from
655dd6a
to
61a5751
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 25, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: d0721f8150891ed541bd2fe06f1c0ce17adda100
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 287b12f8df38e0735dea102b3437ab89cbca3d22
NickGerleman
force-pushed
the
export-D45254098
branch
from
61a5751
to
da9265b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 25, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 869cafce77517f07b8e4d6a5eddc50fcc1418203
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 8c434eef4398982f142abd35ac8c580ec0992d7a
NickGerleman
force-pushed
the
export-D45254098
branch
from
da9265b
to
6a2c04c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 25, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 13da0d1251d5b9ccd01c0723dc122d051cf29d18
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 25, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 27552632fbadc5ebf7f8b731b1c1cf98ed9f472d
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 25b3f66364fd19413ea9c8d225f556e19c0bbd28
NickGerleman
force-pushed
the
export-D45254098
branch
from
6a2c04c
to
52414aa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 26, 2023
Summary: Pull Request resolved: facebook#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 8144cd0904fe2f47b3ebf5ebede3cff0d67ba1d3
NickGerleman
force-pushed
the
export-D45254098
branch
from
52414aa
to
7cb93e3
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 15db2a6f99359d320ddb9c6d21880cb9715cf6dc
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: c122037bae72ae4bf3c3e30e2f212aeb18368e27
NickGerleman
force-pushed
the
export-D45254098
branch
from
349f57c
to
6d39e24
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 4c013a5d9492371404e0956a8fe836ec6ea9e1ba
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: cc028b878d4c24e1b58ba026d87af8f19267c51c
NickGerleman
force-pushed
the
export-D45254098
branch
from
6d39e24
to
3700e7b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 91faea8356d2ac1758ed6e23b05c45aef366debd
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: db3e496d98c610a2397ed41ded07cad72709aa23
NickGerleman
force-pushed
the
export-D45254098
branch
from
3700e7b
to
03664f9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 462641b3d7554d617a8bb0f08febe9d033578386
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: af5881c57b634399e0cb650150072149779bbf9f
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Apr 27, 2023
Summary: Pull Request resolved: facebook#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: a3b21a5bbe727ac4842bd2a4bf88c5285803510c
NickGerleman
force-pushed
the
export-D45254098
branch
from
03664f9
to
bf79e0b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
Summary: Pull Request resolved: facebook#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 55cf5a0e0859a4ce17e3f3a6481a0afe549b6e55
|
This pull request was exported from Phabricator. Differential Revision: D45254098 |
NickGerleman
force-pushed
the
export-D45254098
branch
from
bf79e0b
to
05f636e
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: 599e99faa5399361431e131c7453f197ee8457ff
|
This pull request has been merged in 01c0c4e. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: #37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: d4b61271a8018f548f2d9d8c953db4b121a502d1
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Apr 27, 2023
Summary: X-link: facebook/yoga#1256 X-link: facebook/react-native#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: d4b61271a8018f548f2d9d8c953db4b121a502d1
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: d4b61271a8018f548f2d9d8c953db4b121a502d1
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: X-link: facebook/yoga#1256 Pull Request resolved: facebook#37076 This adds a `YGErrata` bitset enum matching the API and guarantees described in facebook/yoga#1247. It is hooked up in later diffs. There are a couple of `YGExperimentalFeature` values that belong here, but keeping the current options means that the default `YGErrataNone` corresponds to existing default behavior, letting us stage the series of changes as: 1. Implement errata API 2. Update internal Yoga users we want to de-risk to `YGErrataClassic` or `YGErrataAll` (if setting `UseLegacyStretchBehaviour`) 3. Add new errata, changing Yoga defaults to be conformant, while letting internal apps opt into compatibility modes pending experimentation. I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users). Reviewed By: rshest Differential Revision: D45254098 fbshipit-source-id: d4b61271a8018f548f2d9d8c953db4b121a502d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds a
YGErratabitset enum matching the API and guarantees described in #1247.It is hooked up in later diffs. There are a couple of
YGExperimentalFeaturevalues that belong here, but keeping the current options means that the defaultYGErrataNonecorresponds to existing default behavior, letting us stage the series of changes as:YGErrataClassicorYGErrataAll(if settingUseLegacyStretchBehaviour)I also added a macro to let C++ users of Yoga perform bitwise operations on the enum without casting (already available for C users).
Differential Revision: D45254098