Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable compiling against node 8 #313

Merged
merged 1 commit into from
May 28, 2019
Merged

enable compiling against node 8 #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/win/conpty.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@
* with pseudo-terminal file descriptors.
*/

// node versions lower than 10 define this as 0x502 which disables many of the definitions needed to compile
#include <node_version.h>
deepak1556 marked this conversation as resolved.
Show resolved Hide resolved
#if NODE_MODULE_VERSION <= 57
#define _WIN32_WINNT 0x600
deepak1556 marked this conversation as resolved.
Show resolved Hide resolved
#endif

#include <iostream>
#include <nan.h>
#include <Shlwapi.h> // PathCombine, PathIsRelative
Expand Down