Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable compiling against node 8 #313

Merged
merged 1 commit into from
May 28, 2019
Merged

enable compiling against node 8 #313

merged 1 commit into from
May 28, 2019

Conversation

ZoeyR
Copy link
Contributor

@ZoeyR ZoeyR commented May 25, 2019

Fixes #267

@Tyriar Tyriar requested a review from deepak1556 May 25, 2019 15:37
@Tyriar
Copy link
Member

Tyriar commented May 25, 2019

@deepak1556 any harm in adding this?

src/win/conpty.cc Outdated Show resolved Hide resolved
@Tyriar Tyriar added this to the 0.9.0 milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while compiling versions 0.8.0 and above on Windows
3 participants