This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(docs): Set maximum width for examples #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
mnajdova
as code owners
miroslavstastny
commented
May 10, 2019
| @@ -11,7 +11,7 @@ const [notTruncatedText, truncatedText] = [ | |||
| ) | |||
|
|
|||
| const TextExampleTruncatedShorthand = () => ( | |||
| <div style={{ overflow: 'hidden', textOverflow: 'ellipsis', width: 500 }}> | |||
| <div style={{ overflow: 'hidden', textOverflow: 'ellipsis' }}> | |||
There was a problem hiding this comment.
Reverted suboptimal fix from #1019
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
=======================================
Coverage 72.36% 72.36%
=======================================
Files 756 756
Lines 5678 5678
Branches 1662 1662
=======================================
Hits 4109 4109
Misses 1563 1563
Partials 6 6Continue to review full report at Codecov.
|
layershifter
approved these changes
May 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1317.
Before:
After:
The visible overflow is intentional.