This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
docs(layouts): more layout fixes #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
commented
Mar 6, 2019
| <Grid variables={{ gridGap: '2rem' }} columns="1"> | ||
| {children} | ||
| </Grid> | ||
| </> |
There was a problem hiding this comment.
I don't see any reason to use there Flex...
layershifter
commented
Mar 6, 2019
| @@ -79,7 +78,7 @@ class ComponentExample extends React.Component<ComponentExampleProps, ComponentE | |||
| knobs: this.getDefaultKnobsValue(), | |||
| showCode: this.isActiveHash(), | |||
| componentVariables: {}, | |||
| showRtl: examplePath && examplePath.endsWith('rtl') ? true : false, | |||
| showRtl: examplePath && examplePath.endsWith('rtl'), | |||
There was a problem hiding this comment.
Simplified condition
layershifter
commented
Mar 6, 2019
| @@ -56,7 +56,6 @@ interface ComponentExampleState { | |||
| const childrenStyle: React.CSSProperties = { | |||
| paddingTop: 0, | |||
| paddingBottom: '10px', | |||
| maxWidth: pxToRem(500), | |||
There was a problem hiding this comment.
layershifter
commented
Mar 6, 2019
| </Flex.Item> | ||
|
|
||
| {/* TODO: bring back the right floating menu | ||
| <Grid columns="auto 300px" styles={{ justifyContent: 'normal', justifyItems: 'stretch' }}> |
There was a problem hiding this comment.
Fixes this issue:
layershifter
commented
Mar 6, 2019
| @@ -11,7 +11,7 @@ const [notTruncatedText, truncatedText] = [ | |||
| ) | |||
|
|
|||
| const TextExampleTruncated = () => ( | |||
| <div style={{ overflow: 'hidden', textOverflow: 'ellipsis' }}> | |||
| <div style={{ overflow: 'hidden', textOverflow: 'ellipsis', width: 500 }}> | |||
There was a problem hiding this comment.
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1019 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 675 675
Lines 8756 8756
Branches 1558 1558
=======================================
Hits 7138 7138
Misses 1602 1602
Partials 16 16Continue to review full report at Codecov.
|
mnajdova
approved these changes
Mar 6, 2019
As I know there is a plan to move back theme selector |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues work from #1014.