Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide part of code behind feature flag #22529

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Hide part of code behind feature flag #22529

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33b4f4f
Hide part of code behind feature flag
tyler-cai-microsoft Sep 16, 2024
8d024b0
Default to false
tyler-cai-microsoft Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/runtime/container-runtime/src/containerRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1318,6 +1318,7 @@ export class ContainerRuntime
private dirtyContainer: boolean;
private emitDirtyDocumentEvent = true;
private readonly disableAttachReorder: boolean | undefined;
private readonly useDeltaManagerOpsProxy: boolean;
private readonly closeSummarizerDelayMs: number;
private readonly defaultTelemetrySignalSampleCount = 100;
private readonly _signalTracking: IPerfSignalReport = {
Expand Down Expand Up @@ -1622,7 +1623,7 @@ export class ContainerRuntime
);

let outerDeltaManager: IDeltaManager<ISequencedDocumentMessage, IDocumentMessage>;
const useDeltaManagerOpsProxy =
this.useDeltaManagerOpsProxy =
Abe27342 marked this conversation as resolved.
Show resolved Hide resolved
this.mc.config.getBoolean("Fluid.ContainerRuntime.DeltaManagerOpsProxy") !== false;
// The summarizerDeltaManager Proxy is used to lie to the summarizer to convince it is in the right state as a summarizer client.
const summarizerDeltaManagerProxy = new DeltaManagerSummarizerProxy(
Expand All @@ -1632,7 +1633,7 @@ export class ContainerRuntime

// The DeltaManagerPendingOpsProxy is used to control the minimum sequence number
// It allows us to lie to the layers below so that they can maintain enough local state for rebasing ops.
if (useDeltaManagerOpsProxy) {
if (this.useDeltaManagerOpsProxy) {
const pendingOpsDeltaManagerProxy = new DeltaManagerPendingOpsProxy(
summarizerDeltaManagerProxy,
this.pendingStateManager,
Expand Down Expand Up @@ -2909,7 +2910,10 @@ export class ContainerRuntime
const { local, message, savedOp, localOpMetadata } = messageWithContext;

// Set the minimum sequence number to the containerRuntime's understanding of minimum sequence number.
if (this.deltaManager.minimumSequenceNumber < message.minimumSequenceNumber) {
if (
this.useDeltaManagerOpsProxy &&
this.deltaManager.minimumSequenceNumber < message.minimumSequenceNumber
) {
message.minimumSequenceNumber = this.deltaManager.minimumSequenceNumber;
}

Expand Down
Loading