-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide part of code behind feature flag #22529
Merged
tyler-cai-microsoft
merged 2 commits into
microsoft:main
from
tyler-cai-microsoft:hide-part-of-code-behind-feature-flag
Sep 16, 2024
Merged
Hide part of code behind feature flag #22529
tyler-cai-microsoft
merged 2 commits into
microsoft:main
from
tyler-cai-microsoft:hide-part-of-code-behind-feature-flag
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: runtime
Runtime related issues
base: main
PRs targeted against main branch
labels
Sep 16, 2024
Abe27342
approved these changes
Sep 16, 2024
kian-thompson
approved these changes
Sep 16, 2024
Abe27342
reviewed
Sep 16, 2024
⯅ @fluid-example/bundle-size-tests: +568 Bytes
Baseline commit: 5dd8c21 |
tyler-cai-microsoft
added a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Sep 16, 2024
Part of a hotfix There is some minimum sequence number shenanigans going on. Not exactly sure, but we want to be able to safely turn off the feature.
tyler-cai-microsoft
added a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Sep 16, 2024
Part of a hotfix There is some minimum sequence number shenanigans going on. Not exactly sure, but we want to be able to safely turn off the feature.
tyler-cai-microsoft
added a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Sep 16, 2024
Part of a hotfix There is some minimum sequence number shenanigans going on. Not exactly sure, but we want to be able to safely turn off the feature.
This was referenced Sep 16, 2024
tyler-cai-microsoft
added a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Sep 16, 2024
Part of a hotfix There is some minimum sequence number shenanigans going on. Not exactly sure, but we want to be able to safely turn off the feature.
tyler-cai-microsoft
added a commit
to tyler-cai-microsoft/FluidFramework
that referenced
this pull request
Sep 16, 2024
Part of a hotfix There is some minimum sequence number shenanigans going on. Not exactly sure, but we want to be able to safely turn off the feature.
frankmueller-msft
pushed a commit
that referenced
this pull request
Sep 18, 2024
frankmueller-msft
pushed a commit
that referenced
this pull request
Sep 18, 2024
frankmueller-msft
pushed a commit
that referenced
this pull request
Sep 18, 2024
frankmueller-msft
pushed a commit
that referenced
this pull request
Sep 18, 2024
frankmueller-msft
pushed a commit
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature PR: #20856
Part of a hotfix
There is some minimum sequence number shenanigans going on. Not exactly sure, but we want to be able to safely turn off the feature.