fix(client-utils): fix trace.js import of performance

packages/common/client-utils/package.json

@@ -89,7 +89,7 @@
 		"test:mocha": "npm run test:mocha:esm && npm run test:mocha:cjs",
 		"test:mocha:cjs": "mocha --recursive \"dist/test/mocha/**/*.spec.*js\" --exit -r node_modules/@fluid-internal/mocha-test-setup",
 		"test:mocha:esm": "mocha --recursive \"lib/test/mocha/**/*.spec.*js\" --exit -r node_modules/@fluid-internal/mocha-test-setup",
-		"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ./src/cjs/package.json ./dist",
+		"tsc": "fluid-tsc commonjs --project ./tsconfig.cjs.json && copyfiles -f ../../../common/build/build-common/src/cjs/package.json ./dist",
 		"typetests:gen": "flub generate typetests --dir . -v --level public",
 		"typetests:prepare": "flub typetests --dir . --reset --previous --normalize"
 	},

packages/common/client-utils/src/test/jest/trace.spec.ts

@@ -0,0 +1,33 @@
+/*!
+ * Copyright (c) Microsoft Corporation and contributors. All rights reserved.
+ * Licensed under the MIT License.
+ */
+
+import { strict as assert } from "node:assert";
+import { Trace } from "../../index.js";
+
+describe("Trace", () => {
+	test("measure 2ms timeout", async () => {
+		const trace = Trace.start();
+
+		return new Promise((resolve, reject) => {
+			setTimeout(() => {
+				try {
+					const event = trace.trace();
+
+					// While we specify a 2ms timeout, it's possible for performance.now() to measure a
+					// slightly smaller duration due to timing attack and fingerprinting mitigations.
+					// (See https://developer.mozilla.org/en-US/docs/Web/API/Performance/now#security_requirements)
+					//
+					// Therefore, we conservatively require that only 1ms has elapsed.
+					assert(event.duration >= 1);
+					assert(event.totalTimeElapsed >= 1);
+
+					resolve(undefined);
+				} catch (error) {
+					reject(error);
+				}
+			}, 2);
+		});
+	});
+});

packages/common/client-utils/src/test/mocha/trace.spec.ts

@@ -0,0 +1,33 @@
+/*!
+ * Copyright (c) Microsoft Corporation and contributors. All rights reserved.
+ * Licensed under the MIT License.
+ */
+
+import { strict as assert } from "node:assert";
+import { Trace } from "../../index.js";
+
+describe("Trace", () => {
+	it("measure 2ms timeout", async () => {
+		const trace = Trace.start();
+
+		return new Promise((resolve, reject) => {
+			setTimeout(() => {
+				try {
+					const event = trace.trace();
+
+					// While we specify a 2ms timeout, it's possible for performance.now() to measure a
+					// slightly smaller duration due to timing attack and fingerprinting mitigations.
+					// (See https://developer.mozilla.org/en-US/docs/Web/API/Performance/now#security_requirements)
+					//
+					// Therefore, we conservatively require that only 1ms has elapsed.
+					assert(event.duration >= 1);
+					assert(event.totalTimeElapsed >= 1);
+
+					resolve(undefined);
+				} catch (error) {
+					reject(error);
+				}
+			}, 2);
+		});
+	});
+});

packages/common/client-utils/src/trace.ts

@@ -3,7 +3,7 @@
  * Licensed under the MIT License.
  */
 
-import { performance } from "./indexNode.js";
+import { performance } from "./performanceIsomorphic.js";
 
 /**
  * Helper class for tracing performance of events