fix(client-utils): fix trace.js import of performance #21257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DLehenbauer
commented
May 30, 2024
DLehenbauer
commented
May 31, 2024
| @@ -3,7 +3,7 @@ | |||
| * Licensed under the MIT License. | |||
| */ | |||
|
|
|||
| import { performance } from "./indexNode.js"; | |||
| import { performance } from "./performanceIsomorphic.js"; | |||
There was a problem hiding this comment.
This is the actual fix. There is no node/browser specific code involved. PerformanceIsomorphic just narrows the type of the global performance object to the intersection of what browser/node support.
DLehenbauer
commented
May 31, 2024
DLehenbauer
commented
May 31, 2024
DLehenbauer
commented
May 31, 2024
jason-ha
reviewed
May 31, 2024
There was a problem hiding this comment.
Looks like the buffer tests in jest have some typos. There are some things that refer to Node or Browser but are actually the other. The first I noticed was in "Views are supported".
Some small buffer test in mocha would be nice.
Ideally, we'd have tests that used the public interface - @fluid-internal/client-utils. That is entirely possible with either:
- moving tests out from under dist | lib output
- cloning the exports package.json (easier now that they are smaller; restore the file deleted) See also AB#7374.
- not testing CJS (per the package.json not having appropriate exports)
packages/common/client-utils/src/test/mocha/base64Encoding.spec.ts
Outdated
Show resolved
Hide resolved
jason-ha
reviewed
Jun 4, 2024
Co-authored-by: Jason Hartman <jasonha@microsoft.com>
jason-ha
approved these changes
Jun 4, 2024
scottn12
added a commit
to scottn12/FluidFramework
that referenced
this pull request
Jun 5, 2024
Fix GH microsoft#21252 --------- Co-authored-by: Jason Hartman <jasonha@microsoft.com>
scottn12
pushed a commit
to scottn12/FluidFramework
that referenced
this pull request
Jun 5, 2024
Fix GH microsoft#21252 --------- Co-authored-by: Jason Hartman <jasonha@microsoft.com>
scottn12
pushed a commit
to scottn12/FluidFramework
that referenced
this pull request
Jun 5, 2024
Fix GH microsoft#21252 --------- Co-authored-by: Jason Hartman <jasonha@microsoft.com>
scottn12
pushed a commit
to scottn12/FluidFramework
that referenced
this pull request
Jun 5, 2024
Fix GH microsoft#21252 --------- Co-authored-by: Jason Hartman <jasonha@microsoft.com>
scottn12
pushed a commit
to scottn12/FluidFramework
that referenced
this pull request
Jun 5, 2024
Fix GH microsoft#21252 --------- Co-authored-by: Jason Hartman <jasonha@microsoft.com>
scottn12
added a commit
that referenced
this pull request
Jun 5, 2024
scottn12
added a commit
that referenced
this pull request
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GH #21252