Thrown errors in client sagas are now logged to console. #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
srinaath and
tdurnford
as code owners
tonyanziano
force-pushed
the
toanzian/restart-fix
branch
from
bffe200
to
3126dd1
Compare
tonyanziano
commented
Feb 27, 2020
| @@ -50,13 +50,18 @@ export function* throwErrorFromResponse(errorMessage: string, response: Response | |||
| status, | |||
| }; | |||
| if (text) { | |||
| const errText = yield text(); | |||
| const errText = yield text.call(response); | |||
There was a problem hiding this comment.
This was also throwing the following error:
TypeError: Failed to execute 'text' on 'Response': Illegal invocation
because text() was being called outside of the response context.
There was a problem hiding this comment.
I think this is good for now. But we just do a try catch block around all our sagas and log them.
srinaath
approved these changes
Feb 28, 2020
| @@ -50,13 +50,18 @@ export function* throwErrorFromResponse(errorMessage: string, response: Response | |||
| status, | |||
| }; | |||
| if (text) { | |||
| const errText = yield text(); | |||
| const errText = yield text.call(response); | |||
There was a problem hiding this comment.
I think this is good for now. But we just do a try catch block around all our sagas and log them.
|
@srinaath once we bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help debug issues like #2086
===
Due to the way sagas work, the errors thrown in our nested sagas are seen as uncaught and redux saga hides most of the internal properties of the thrown error and just shows the
message, which isn't very helpful.redux-sagaprovides anonErrorhook that you can use for catching these errors at the root level, but theonErrorwill only get called if the caught error is of typeError. Since we defined our own error typeResponseErrortheonErrorhook never gets called. We need to update toredux-saga@1.0.0for that check to be fixed, but this might incur some other breaking changes that I don't think this PR should deal with. See this issue for reference.For now, we will surface the error in its entirety through
console.error().Before the change:
After the change: