Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator update does not restart conversation which requires a close and re-open of the app. #2086

Closed
xtianus79 opened this issue Feb 26, 2020 · 10 comments
Assignees
Labels
Bot Services equired for internal Azure reporting. Do not delete. Do not change color. Bug Your classic code defect customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@xtianus79
Copy link

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

Version 4.7.0-107479 (4.7.0-107479.107479)

Describe the bug

restart conversation doesn't seem to have any affect on the emulator. Thus needing to close and reopen after every change.

To Reproduce

Steps to reproduce the behavior:
setup a bot and click restart conversation.

to restart

[bug]

@xtianus79 xtianus79 added the Bug Your classic code defect label Feb 26, 2020
@tonyanziano
Copy link
Contributor

@xtianus79 could you please press (Ctrl + Shift + I for Windows, or Cmd + Shift + I for Mac) in order to open the developer tools window, and try clicking the Restart Conversation button?

Once you do, please send a screenshot of the console tab with any error messages.

I have tried reproducing this on version 4.7.0-107479 and the button works as expected for me.

@xtianus79
Copy link
Author

here is image @tonyanziano this is the screenshot. It works sometimes but after it breaks it won't refresh anymore.

@jwiley84 jwiley84 added Bot Services equired for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Feb 27, 2020
@tonyanziano
Copy link
Contributor

@xtianus79 thanks for the screenshot, that's very helpful.

I think I may know where this error is originating from. I'll take a look.

@tonyanziano
Copy link
Contributor

I have found the issue that is causing the error you are seeing. The error is resulting from this line here, because we are calling text() outside of the context of response which is wrong.

However, once I fixed that, I noticed that the code is still not surfacing the correct error that you should be seeing which is the result of not being able to post an activity to your bot. I'm working on fixing that now.

@tonyanziano tonyanziano added the customer-replied-to Required for internal reporting. Do not delete. label Feb 27, 2020
@tonyanziano
Copy link
Contributor

@xtianus79 There is a PR out #2087, that will show a more detailed error in the console so we can debug why restarting a conversation is sometimes failing for you.

@tonyanziano tonyanziano self-assigned this Feb 28, 2020
@tonyanziano
Copy link
Contributor

Hi @xtianus79 ,

Please update to the newest nightly version, 4.7.0-109326, and try to reproduce this issue again.

When you run into the issue, open the dev tools console window, and you should now see a detailed error message about what went wrong. Feel free to post that error here and we can help you debug.

@xtianus79
Copy link
Author

@tonyanziano yes that is working!!! thank you sir

@xtianus79
Copy link
Author

@tonyanziano the emulator still seems to have memory issues. Refresh now works sometimes and the need to open and close the emulator to reuse it.

@xtianus79 xtianus79 reopened this Mar 4, 2020
@tonyanziano
Copy link
Contributor

@xtianus79 can you please open the dev tools and take a screenshot of the console tab with any errors when you encounter this issue again?

@cwhitten
Copy link
Member

closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services equired for internal Azure reporting. Do not delete. Do not change color. Bug Your classic code defect customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Development

No branches or pull requests

4 participants