-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2042] Changed convo infrastructure to use Web Sockets. #2034
Conversation
packages/app/client/src/ui/editor/emulator/emulatorContainer.ts
Outdated
Show resolved
Hide resolved
packages/app/main/src/server/routes/channel/conversations/handlers/createConversation.ts
Outdated
Show resolved
Hide resolved
packages/app/main/src/server/routes/emulator/handlers/updateConversation.ts
Show resolved
Hide resolved
packages/app/main/src/server/routes/emulator/handlers/updateConversation.ts
Outdated
Show resolved
Hide resolved
960a6d0
to
c026480
Compare
c026480
to
b627ece
Compare
I think the coverage number has gone down as a result of removing a lot of tested code, but I will try to write some more to lessen the drop. |
Opened another PR with a bunch of new tests to compensate for drop in code coverage: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments or nice to have's.. Looks awesome 👍
related to #1405 , #2042
===
Highlights
emulator.tsx
componentbotSagas.ts
andchatSagas.ts
so now they can be called more declaratively instead of relying on changes to props satisfying the right criteria.chat
file versus a.transcript
file.chat
file, we first usechatdown
to convert the file to a transcript before extracting the activitiesSetCurrentUser
command and manually maintaining the stateusers
property from persistedserver.json
file (no more endless list of randomly generated user IDs from previous sessions)Passing E2E tests:
Diagram of High-level Changes