Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add local directLine websocket handling into the Bot Emulator Framework #1405

Closed
vseanclark opened this issue Apr 2, 2019 · 3 comments
Assignees
Labels
Bot Services equired for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. Enhancement New feature or request to evolve an additional feature P1 Painful if we don't fix, won't block releasing T-Shirt: L 2 - 5 Days

Comments

@vseanclark
Copy link

We have implemented a custom channel that is dependent on the directLine messages via the websocket.  When running with the Bot Emulator Framework locally, we do not receive these websocket messages as documented.  Because of this, our local code behaves differently than the code when executed in the cloud.  

Our enterprise policy does not allow using NGROK as the suggested workaround for this issue.

We request the addition of the local directLine websocket handling into the Bot Emulator Framework.

@justinwilaby
Copy link
Contributor

justinwilaby commented Apr 2, 2019

@vseanclark -

DirectLine is undergoing a major overhaul which may mandate the use of websockets. Once this is fully baked, we will implement the new protocol in the Emulator.

With that said, I will open a discussion with the team about whether or not we want to implement the existing protocol via websockets. In the meantime, keep an eye on #1394 since this feature will allow you to use any channel for locally running bots including direct line via web sockets and sill connect to the Emulator.

Also, refer to the docs in #1393 for an example on how this works. Although ngrok is still required (really, any tunnel that points to a local host), it may work for your scenario until we can get directline websockets in the Emulator.

@jameslew jameslew added 4.6 Customer As opposed to development work item. Enhancement New feature or request to evolve an additional feature labels Jul 23, 2019
@cwhitten cwhitten added P1 Painful if we don't fix, won't block releasing T-Shirt: L 2 - 5 Days labels Aug 1, 2019
@cwhitten cwhitten removed the 4.6 label Sep 25, 2019
@tonyanziano tonyanziano self-assigned this Nov 5, 2019
@tonyanziano
Copy link
Contributor

@vseanclark we have just merged in a PR (#2034) that switches communication between the client (Web Chat) and the Emulator to Web Sockets instead of REST polling via GET.

It may be worth checking out to see if it resolves your issues.

It will be available in the newest nightly at around 10:30 PM PST tonight.

@cwhitten
Copy link
Member

Closing as fixed!

@cwhitten cwhitten added Bot Services equired for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. and removed Customer As opposed to development work item. labels Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services equired for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. Enhancement New feature or request to evolve an additional feature P1 Painful if we don't fix, won't block releasing T-Shirt: L 2 - 5 Days
Projects
None yet
Development

No branches or pull requests

5 participants