Bugfix: songs being dropped when adding them to the queue

[michael-je]

This PR fixes a bug where songs are often dropped when trying to add them to the queue. It does this by fixing the "dislike_count" error that popped up after youtube removed dislikes on their videos.

A side effect is that it seems to speed up the time it takes to add multiple songs to the queue, so it might help with #49 (comment).

I've simply customized pafy.new() so that the _dislikes variable of its youtube backend has a default value if none is found.

I'll probably add a PR to the pafy repository as well Someone beat me to it: mps-youtube/pafy#305. In the meantime though, this dirty fix should do the trick.

[morgaesis]

I don't like copying pafy source (with modifications) to fix something which should be solved upstream. We should rather pressure the upstream pafy repo to fix this and publish the update.

Our bot isn't critical, nor in widespread usage, so I don't this PR is warranted, at least not like this. If we had many users and some promise of uptime, that'd be a different story.

[michael-je]

What's the issue?

I've already done what I can to pressure this upstream by approving the PR I linked.
I would like the bot to be functional so that we can use it.
These changes can be removed at any moment, and without breaking anything, by changing a single line in the main script.
The source code is under the LGPLv3 license, so no issue there.
Also, the last update release on the pafy repository is from 2 years ago, so we really have no idea when this will be resolved upstream.

And most importantly...it works :o

[morgaesis]

All right. I thought the pafy repo were actively maintained. Disregard my last comment.

If we copy the source from a GPL repo, we might need to set the licence for this repo to GPL as well. Currently there is no licence.

[morgaesis]

LGTM 👍

• Some ideas for handling lack of *like_count.
• Please add a licence to this repo. I don't know how to lawyer; can the licence be MIT? Apache? GPL? I think GPLv3 is a safe choice, since the code you're "borrowing" is GPLv3 as well.

[michael-je]

Fixed :) thanks for reminding me about the license!