Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement playlist support #49

Merged
merged 14 commits into from
Nov 25, 2021
Merged

Implement playlist support #49

merged 14 commits into from
Nov 25, 2021

Conversation

morgaesis
Copy link
Collaborator

@morgaesis morgaesis commented Nov 15, 2021 •
edited
Loading

  • Adds youtube playlist support
  • Reacts to playlist play request
  • Immediately plays first song
  • Shows progress of fetching playlist songs
  • When fetching playlist is complete, shows first 10 songs in playlist
  • Shows how many songs were added
  • Shows how many songs were in playlist
  • Makes next_in_queue an async function

Closes #23

@morgaesis morgaesis requested review from thorduragust, michael-je and gardarandri and removed request for thorduragust November 15, 2021 21:58
gardarandri
gardarandri approved these changes Nov 18, 2021
View reviewed changes
bot.py Outdated Show resolved Hide resolved
bot.py Outdated Show resolved Hide resolved
michael-je
michael-je reviewed Nov 18, 2021
View reviewed changes
bot.py Outdated Show resolved Hide resolved
morgaesis and others added 2 commits November 20, 2021 12:06
@morgaesis @gardarandri
Update bot.py
70b9293 
Co-authored-by: gardarandri <gardarsig95@gmail.com>
@morgaesis
Don't skip when adding playlist
4cb0dea
@michael-je michael-je mentioned this pull request Nov 23, 2021
Merged
@morgaesis
Copy link
Collaborator Author

I think another review is warranted

michael-je
michael-je reviewed Nov 25, 2021
View reviewed changes
bot.py Outdated Show resolved Hide resolved
@morgaesis @michael-je
re.findall -> re.search
5752ad9 
Co-authored-by: Michael Joseph <mikkmakk89@gmail.com>
michael-je
michael-je approved these changes Nov 25, 2021
View reviewed changes
Copy link
Owner

@michael-je michael-je left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice, good work :)

As it stands though the bot is blocked while fetching the playlist data. This needs to be resolved imo, but I'm ok with merging this PR first and adding that as a new issue.

@morgaesis morgaesis merged commit 2f812d2 into michael-je:master Nov 25, 2021
@morgaesis morgaesis deleted the playlist branch November 25, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-je michael-je michael-je approved these changes

@gardarandri gardarandri Awaiting requested review from gardarandri

@thorduragust thorduragust Awaiting requested review from thorduragust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add feature to allow the bot to play youtube playlists
3 participants
@morgaesis @gardarandri @michael-je