segment should remove all trailing/leading slashes #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1553,6 +1553,7 @@ | |||
| var path = this.path(); | |||
| var absolute = path.substring(0, 1) === '/'; | |||
| var segments = path.split(separator); | |||
| var noLeadTrailSlashRegex = /^\/*|\/*$/g; | |||
There was a problem hiding this comment.
shouldn't that be /^\/+|\/+$/g; (+ (one or more) instead of * (zero or more))?
There was a problem hiding this comment.
yes you are right, I'll fix this
|
ping @orlando :) |
|
@rodneyrehm PR updated |
rodneyrehm
added a commit
that referenced
this pull request
Oct 5, 2015
fix(segment): trimming leading and trailing slashes from input
rodneyrehm
added a commit
that referenced
this pull request
Oct 5, 2015
rodneyrehm
added a commit
that referenced
this pull request
Oct 5, 2015
|
thank you very much! :) |
|
released in v1.17.0 |
|
🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes leading and trailing slashes from
segmentFixes #236