Should segment() take care of leading slash?

[orlando]

I'm using URI.js to append a cdn host to URLs, the problem is that some assets have a leading slash and other don't.

Should segment() method take care of this?

Example

URI('https://google.com').segment('font.ttf').toString() //-> https://google.com/font.ttf
URI('https://google.com').segment('/font.ttf').toString() //-> https://google.com//font.ttf

Result of second example should be like the first one.

Thanks!

[rodneyrehm]

is it possible you're looking for .absoluteTo() instead?

URI('font.ttf').absoluteTo('https://google.com/').toString()
// https://google.com/font.ttf
URI('/font.ttf').absoluteTo('https://google.com/').toString()
// https://google.com/font.ttf
URI('font.ttf').absoluteTo('https://google.com/somewhere/').toString()
// https://google.com/somewhere/font.ttf
URI('/font.ttf').absoluteTo('https://google.com/somewhere/').toString()
// https://google.com/font.ttf

But to answer your question: the .segment() function is nothing but a helper to split and join paths. There also is .segmentCoded() to take care of en/decoding segments. There is no logic along the lines of "is the value to set a segment, or really an entire path". I'm not sure this should be added, as you may very well replace a given segment by foo/bar, which is valid.

Removing leading and trailing slashes would be a convenience thing. Feel free to submit a PR for that :)

[orlando]

@rodneyrehm abosoluteTo() works for this use case.

if you think segment() should do this, I can implement it. Do you have any suggestion about the API, or instead sanitize leading/trailing slashes by default?

[rodneyrehm]

if you think segment() should do this, I can implement it. Do you have any suggestion about the API, or instead sanitize leading/trailing slashes by default?

leading and trailing / make no sense in a segment, so'd trim them by default.

[orlando]

Perfect, I'll work on this over the weekend.

Thanks!

[rodneyrehm]

any progress on this, @orlando?

[orlando]

@rodneyrehm actually I made the fix, but totally forgot about the PR. Thanks for the heads up, I'll make the PR between tonight and tomorrow.

[rodneyrehm]

any progress on the PR, @orlando?

[orlando]

@rodneyrehm PR up

[rodneyrehm]

released in v1.17.0