Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly remove per-device push rules #637

Closed
ara4n opened this issue Jun 9, 2020 · 5 comments · Fixed by #1842
Closed

properly remove per-device push rules #637

ara4n opened this issue Jun 9, 2020 · 5 comments · Fixed by #1842
Assignees
Labels
A-Client-Server Issues affecting the CS API A-Push clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@ara4n
Copy link
Member

ara4n commented Jun 9, 2020

the APIs are still hanging around, which confuses people. we should add them back to the spec deliberately in future

@richvdh
Copy link
Member

richvdh commented Jun 10, 2020

@ara4n: which APIs does this refer to specifically?

@richvdh
Copy link
Member

richvdh commented Jun 12, 2020

synapse returns an undocumented devices property in response to GET /_matrix/client/r0/pushrules/, so maybe that is what this is referring to? but removing that would be a synapse bug rather than a spec one.

@turt2live turt2live added clarification An area where the expected behaviour is understood, but the spec could do with being more explicit A-Client-Server Issues affecting the CS API A-Push question Further information is requested labels Jun 12, 2020
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@richvdh richvdh removed the question Further information is requested label Mar 2, 2022
@richvdh
Copy link
Member

richvdh commented Apr 14, 2022

I've opened matrix-org/synapse#12482 to track updating the Synapse API.

As it concerns the spec, device scopes are mentioned in a couple of places: https://spec.matrix.org/v1.2/client-server-api/#get_matrixclientv3pushrulesscopekindruleidactions and https://spec.matrix.org/v1.2/client-server-api/#get_matrixclientv3pushrulesscopekindruleidenabled, which both say:

scope: Required: Either global or device/<profile_tag> to specify global rules or device rules for the given profile_tag.

Synapse returns a 400 M_UNRECOGNIZED for any such request where scope is not global.

@frederikb96
Copy link

Do I understand correctly, that the per device push rules are going to be removed and that there will be no way to have different notification profiles for different devices?

@richvdh
Copy link
Member

richvdh commented Mar 27, 2023

Per-device push rules have never been supported. There have been some ideas for supporting per-device notification profiles in Matrix, but it won't be based on push rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client-Server Issues affecting the CS API A-Push clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants