Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete references to device-specific push rules #3966

Closed
wants to merge 1 commit into from

Conversation

jgarplind
Copy link
Contributor

@jgarplind jgarplind commented Dec 18, 2023

Checklist

  • Tests written for new code (and old code if feasible) Should be covered by existing tests, if any
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Been reading up on push rules, and specifically how the only supported (as per the spec) scope is global, e.g. here: matrix-org/matrix-spec#637

I also found this old PR which did the most important parts, but then ran across some parts that unnecessarily catered for a no longer supported use case. Figured it could be a good opportunity to make a minor contribution to a much appreciated repo.

I also considered the possibility to adjust the function signatures to either not take scope, or to force it to be the literal "global", but I'm not sure if that is desirable, with regards to API stability, etc.


This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

Copy link
Contributor

Thanks for opening this pull request, unfortunately we do not accept contributions from the main branch of your fork, please re-open once you switch to an alternative branch for everyone's sanity. See https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant