Remove obsolete references to device-specific push rules #3967
Conversation
github-actions
bot
added
Z-Community-PR
| // NB. Scope not uri encoded because devices need the '/' | ||
| const path = utils.encodeUri("/pushrules/" + scope + "/$kind/$ruleId", { | ||
| const path = utils.encodeUri("/pushrules/$scope/$kind/$ruleId", { | ||
| $scope: scope, |
There was a problem hiding this comment.
I don't really see that this is a worthwhile improvement. It doesn't actually remove the redundant scope param (which would be a concrete improvement, though hard to do without breaking backwards compatibility); rather it just url-encodes it. Since scope must always be global, this seems to make no difference at all?
There was a problem hiding this comment.
I agree. It is a miniscule improvement to legibility / removing redundant comments which may confuse, and the PR description echoes your sentiment about preserving backwards compatibility.
Was hoping that a small touch-up would be appreciated, but if you prefer to keep things as they are, I'm content to cancel this PR as well.
There was a problem hiding this comment.
Yeah, let's leave it; I don't think it's worthwhile.
Maybe in future we can create addGlobalPushRule etc which omit the scope param; then we can deprecate the existing methods.
|
Thanks for the contribution anyway! |
Checklist
Been reading up on push rules, and specifically how the only supported (as per the spec) scope is
global, e.g. here: matrix-org/matrix-spec#637I also found this old PR which did the most important parts, but then ran across some parts that unnecessarily catered for a no longer supported use case. Figured it could be a good opportunity to make a minor contribution to a much appreciated repo.
I also considered the possibility to adjust the function signatures to either not take
scope, or to force it to be the literal"global", but I'm not sure if that is desirable, with regards to API stability, etc.Type: [task]
This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.