-
-
Notifications
You must be signed in to change notification settings - Fork 832
Add option to stop sending read receipts (delabs MSC2285: private read receipts) #8629
Conversation
ba04128
to
53c50ea
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx
Outdated
Show resolved
Hide resolved
src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Travis Ralston <travisr@matrix.org>
@janogarcia I think you're best positioned to take a look at this to carry context forward to the upcoming settings redesign. For now, I think we just want to find a sensible home in our current settings. From the PR screenshot it looks like it's currently placed in a 'Privacy' section, but I'm not sure this is a natural place to reach. I think it should be placed in the 'Preferences' section. I've also continually observed users at a loss to what 'Presence' means so think we need to rephrase to more intuitive and predictable language. |
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm code-wise
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
…rr-delabs Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good to me.
Product/QA: if a testing environment is needed, please ping me.
src/components/views/settings/tabs/user/PreferencesUserSettingsTab.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Travis Ralston <travisr@matrix.org>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
src/components/views/settings/tabs/user/PreferencesUserSettingsTab.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
I am unfamiliar with the release process of Element and how it relates to matrix-react-sdk. Could someone explain whether this is or will be part of both Element Web and Element Android, and if so whether it has already been released or when it will be released? |
Fixes element-hq/element-web#2527
Requires matrix-org/matrix-spec-proposals#2285
Requires matrix-org/matrix-js-sdk#2524
Requires element-hq/element-web#22242
Requires matrix-org/synapse#13273
Notes: Add option to stop sending read receipts (
Preferences
->Presence
->Send read receipts
)This PR moves
Send read receipts
setting out of labs intoPreferences
->Presence
. It also movesSend typing notification
into that section for consistency.This change is marked as an internal change (Task), so will not be included in the changelog.