Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add option to stop sending read receipts (delabs MSC2285: private read receipts) #8629

Merged
merged 40 commits into from
Aug 5, 2022

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented May 17, 2022

Fixes element-hq/element-web#2527
Requires matrix-org/matrix-spec-proposals#2285
Requires matrix-org/matrix-js-sdk#2524
Requires element-hq/element-web#22242
Requires matrix-org/synapse#13273

Notes: Add option to stop sending read receipts (Preferences -> Presence -> Send read receipts)


2022-06-14_20-15

This PR moves Send read receipts setting out of labs into Preferences -> Presence. It also moves Send typing notification into that section for consistency.


This change is marked as an internal change (Task), so will not be included in the changelog.

@SimonBrandner SimonBrandner added X-Blocked The PR cannot move forward in any capacity until an action is made T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels May 17, 2022
@SimonBrandner SimonBrandner requested a review from a team as a code owner May 17, 2022 14:59
@SimonBrandner SimonBrandner requested a review from a team May 17, 2022 15:01
@SimonBrandner SimonBrandner force-pushed the SimonBrandner/feat/disable-rr branch from ba04128 to 53c50ea Compare May 17, 2022 15:05
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
src/components/views/elements/SettingsFlag.tsx Outdated Show resolved Hide resolved
src/components/views/elements/SettingsFlag.tsx Outdated Show resolved Hide resolved
src/settings/Settings.tsx Show resolved Hide resolved
src/components/structures/TimelinePanel.tsx Show resolved Hide resolved
@turt2live turt2live requested a review from a team May 18, 2022 04:19
Co-authored-by: Travis Ralston <travisr@matrix.org>
@nadonomy
Copy link
Contributor

@janogarcia I think you're best positioned to take a look at this to carry context forward to the upcoming settings redesign. For now, I think we just want to find a sensible home in our current settings.

From the PR screenshot it looks like it's currently placed in a 'Privacy' section, but I'm not sure this is a natural place to reach. I think it should be placed in the 'Preferences' section.

I've also continually observed users at a loss to what 'Presence' means so think we need to rephrase to more intuitive and predictable language.

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm code-wise

src/components/structures/TimelinePanel.tsx Outdated Show resolved Hide resolved
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
…rr-delabs

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner changed the title Switch to stable prefixes for MSC2285 Add option to stop sending read receipts (delabs MSC2285: private read receipts) Aug 4, 2022
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me.

Product/QA: if a testing environment is needed, please ping me.

src/components/structures/TimelinePanel.tsx Outdated Show resolved Hide resolved
Co-authored-by: Travis Ralston <travisr@matrix.org>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@cdauth
Copy link

cdauth commented Dec 14, 2022

I am unfamiliar with the release process of Element and how it relates to matrix-react-sdk. Could someone explain whether this is or will be part of both Element Web and Element Android, and if so whether it has already been released or when it will be released?

@t3chguy
Copy link
Member

t3chguy commented Dec 14, 2022

Element Android is a separate codebase. This has been in Element Web & Desktop for multiple versions.

image

Your server must advertise support for it though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to stop sending read receipts to other users
7 participants