Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove docs for feature_hidden_read_receipts #22242

Merged
merged 4 commits into from
Aug 5, 2022
Merged

Remove docs for feature_hidden_read_receipts #22242

merged 4 commits into from
Aug 5, 2022

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented May 17, 2022 •
edited by github-actions bot
Loading

Requires matrix-org/matrix-react-sdk#9128

This change is marked as an internal change (Task), so will not be included in the changelog.

@SimonBrandner SimonBrandner added T-Task Tasks for the team like planning X-Blocked labels May 17, 2022
@SimonBrandner SimonBrandner requested a review from a team as a code owner May 17, 2022 15:00
@SimonBrandner SimonBrandner force-pushed the SimonBrandner/feat/disable-rr branch from 45e380b to b4c379f Compare May 17, 2022 15:00
@SimonBrandner
Remove docs for feature_hidden_read_receipts
b4c379f 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner mentioned this pull request May 17, 2022
Merged
turt2live
turt2live requested changes May 17, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title != implementation

@SimonBrandner SimonBrandner changed the title Remove docs for feature_message_right_click_context_menu Remove docs for feature_hidden_read_receipts May 17, 2022
@SimonBrandner
Copy link
Contributor Author

Title != implementation

Haha, let's pretend that did not happen

This was referenced Jul 14, 2022
Merged
Merged
@SimonBrandner SimonBrandner mentioned this pull request Aug 3, 2022
Closed
@SimonBrandner SimonBrandner marked this pull request as draft August 3, 2022 10:01
turt2live
turt2live approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, fwiw :)

(pretty sure this isn't supposed to be a draft?)

@SimonBrandner SimonBrandner marked this pull request as ready for review August 5, 2022 04:15
@SimonBrandner SimonBrandner merged commit 039141f into develop Aug 5, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/feat/disable-rr branch August 5, 2022 15:34
@boontifex
Copy link

Hello,
we are seaching for the config.json option to disable sendReadReceipts per default, is this available?

@SimonBrandner
Copy link
Contributor Author

Hello, we are seaching for the config.json option to disable sendReadReceipts per default, is this available?

Hi, no, we don't have that atm, I would suggest you open an issue for this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonBrandner @boontifex @turt2live