This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Update dark theme bg-color to show hover effect on messages #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @jryans is getting direction from Nad on this - asking for specific review. |
jryans
suggested changes
Feb 16, 2019
There was a problem hiding this comment.
My current understanding is that the palette colors shouldn't be modified directly, but instead the more likely change will be to route a different color from the palette to the hover effect or in some cases update a more specific variable to use a special color outside the palette when needed.
Since Nad mentions #111316 in element-hq/element-web#8580, I think it means you should set $event-selected-color to this value.
Signed-off-by: Aaron Raimist <aaron@raim.ist>
aaronraimist
force-pushed
the
dark-bg-color-update
branch
from
5632e61
to
9318c4e
Compare
jryans
approved these changes
Feb 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8580