Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme follow up issues #8554

Closed
jryans opened this issue Feb 13, 2019 · 37 comments
Closed

Dark theme follow up issues #8554

jryans opened this issue Feb 13, 2019 · 37 comments
Labels
A-Pills A-Themes-Official Official themes (light, dark) A-Theming P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@jryans
Copy link
Collaborator

jryans commented Feb 13, 2019

No description provided.

@nadonomy
Copy link
Contributor

nadonomy commented Feb 13, 2019

Awesome! Small stuff, but:

  • E2E icons should use primary/notice colours (fixed in matrix-org/matrix-react-sdk@feb9295)
  • Vertical bar splitting top right icons isn't skinned (should we take the primary icon colour and apply 50% opacity?) (fixed in matrix-org/matrix-react-sdk@4409636)
  • (+) icons in room list not skinned
  • @mention backgrounds not skinned (for now using the room highlight bg would be ok) (fixed in matrix-org/matrix-react-sdk@4227500)
  • Adjust gradient to use rgba for Safari (fixed in matrix-org/matrix-react-sdk@5f6907c)
  • Change box shadow on top left menu to use bg value (fixed in matrix-org/matrix-react-sdk@f64f39f)
  • LLP should be #15171B not #1C1F24 (subtle, but important to establish the same depth hierarchy as the light theme)
  • E2E composer decoration, and message hover decoration should use new palette (we're missing a yellow, maybe use the orange if we don't have a yellow when you tackle this)

@jryans
Copy link
Collaborator Author

jryans commented Feb 13, 2019

@jryans jryans self-assigned this Feb 13, 2019
@aaronraimist
Copy link
Collaborator

aaronraimist commented Feb 13, 2019

  • Markdown button status appears reversed
    image
  • Should there be a more visible vertical line here?
    image
    image
  • It would be nice to use a white [m] logo in the room directory
    image
  • "INVITED" in user list is hard to see (Set h3-color in dark theme matrix-org/matrix-react-sdk#2656)
    screen shot 2019-02-13 at 7 47 37 am
  • Room settings that you can't update are hard to read
    screen shot 2019-02-13 at 7 48 46 am
  • Safari scrollbars are dark but (one of the) Firefox scrollbars is light. Which is intended? Is Gemini getting killed before 1.0?

@Half-Shot

This comment has been minimized.

@anoadragon453
Copy link
Member

anoadragon453 commented Feb 13, 2019

@turt2live
Copy link
Member

turt2live commented Feb 13, 2019

@turt2live
Copy link
Member

turt2live commented Feb 13, 2019

  • Widgets blend in with the timeline
    image

@nadonomy
Copy link
Contributor

nadonomy commented Feb 13, 2019

@jryans re widgets blending; they should be using the header/panel background colour

@Half-Shot
Copy link
Member

(could people put names next to their issues if possible so I don't have to mouse over all of them?)

@Cadair
Copy link

Cadair commented Feb 13, 2019

The spinner looks particularly bad on the dark theme I think. It's got a white line around the edges etc.

image

@Cadair
Copy link

Cadair commented Feb 13, 2019

image

@turt2live
Copy link
Member

re: redaction bar. There is a dark theme asset from the old design somewhere.
image

@jryans
Copy link
Collaborator Author

jryans commented Feb 14, 2019

@jryans
Copy link
Collaborator Author

jryans commented Feb 14, 2019

@nadonomy
Copy link
Contributor

nadonomy commented Feb 14, 2019

  • 'back' Chevron in member panel

screenshot 2019-02-14 at 18 31 30

@turt2live
Copy link
Member

turt2live commented Feb 14, 2019

@Cadair

This comment has been minimized.

@turt2live
Copy link
Member

@Half-Shot
Copy link
Member

@Cadair #8554 (comment) :)

@turt2live
Copy link
Member

turt2live commented Feb 15, 2019

@jryans
Copy link
Collaborator Author

jryans commented Feb 15, 2019

@progserega

This comment has been minimized.

@jryans
Copy link
Collaborator Author

jryans commented Feb 18, 2019

@jryans
Copy link
Collaborator Author

jryans commented Feb 18, 2019

@anoadragon453
Copy link
Member

anoadragon453 commented Mar 5, 2019

@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist and removed redesign labels Mar 14, 2019
@SilverWolf32
Copy link

Spinners should definitely be inverted to match the background. I don't know if this is OS X-specific, but on here it looks awful.

The spinner on a dark background

@SilverWolf32
Copy link

Also, the desktop app's window title bar on OS X is still light, even when using the dark theme. I'm not quite sure whether to put that here or somewhere else, since it's desktop-specific, but it's definitely noticeable, pretty much forcing me to use the client full screen. (The latest OS X has system-wide dark mode, and apps have to explicitly opt in to get dark-themed.)

@lampholder lampholder added the P1 label Apr 30, 2019
@dkasak
Copy link
Member

dkasak commented Aug 24, 2019

Username highlights on the dark theme look awful while unselected due to the brownish background colour:

unselected

It's a bit better when selected since it then changes to a grey shade:

selected

@Mattwmaster58
Copy link

Also, the desktop app's window title bar on OS X is still light

This is also the case with Windows

@t3chguy
Copy link
Member

t3chguy commented Mar 9, 2020

When inactive yes, when active it matches the theme colour as expected.

image

@Mattwmaster58
Copy link

Mattwmaster58 commented Mar 10, 2020

@t3chguy, huh, that's strange. Here's a screenshot with the window active:
Annotation 2020-03-09 192258

I've never seen the title bar styled properly.

riot-web version: 1.5.12
olm version: 3.1.3

@t3chguy
Copy link
Member

t3chguy commented Mar 10, 2020

image

What does your explorer window look like in comparison?

@Mattwmaster58
Copy link

Dark - I have windows dark theme on. I have set 'follow system theme set' in riot web settings

image

@HelderFSFerreira
Copy link
Contributor

I have the same issue as @Mattwmaster58 on windows 10 with dark mode enabled.

@MadLittleMods
Copy link
Contributor

Are we good to close this? I count only 3 remaining unchecked tasks. Two of which need issues if they're still actually problems anyway. And I assume there has been a lot more iteration than linked here.

@turt2live
Copy link
Member

Yea, I think if there's any remaining issues then independent ones would be best :)

su-ex added a commit to SchildiChat/element-web that referenced this issue May 28, 2022
* Go to space landing page when clicking on a selected space ([\element-hq#6442](matrix-org/matrix-react-sdk#6442)). Fixes element-hq#20296.
* Fall back to untranslated string rather than showing missing translation error ([\element-hq#8609](matrix-org/matrix-react-sdk#8609)).
* Show file name and size on images on hover ([\element-hq#6511](matrix-org/matrix-react-sdk#6511)). Fixes element-hq#18197.
* Iterate on search results for message bubbles ([\element-hq#7047](matrix-org/matrix-react-sdk#7047)). Fixes element-hq#20315.
* registration: redesign email verification page ([\element-hq#8554](matrix-org/matrix-react-sdk#8554)). Fixes element-hq#21984.
* Show full thread message in hover title on thread summary ([\element-hq#8568](matrix-org/matrix-react-sdk#8568)). Fixes element-hq#22037.
* Tweak video rooms copy ([\element-hq#8582](matrix-org/matrix-react-sdk#8582)). Fixes element-hq#22176.
* Live location share - beacon tooltip in maximised view ([\element-hq#8572](matrix-org/matrix-react-sdk#8572)).
* Add dialog to navigate long room topics ([\element-hq#8517](matrix-org/matrix-react-sdk#8517)). Fixes element-hq#9623.
* Change spaceroomfacepile tooltip if memberlist is shown ([\element-hq#8571](matrix-org/matrix-react-sdk#8571)). Fixes element-hq#17406.
* Improve message editing UI ([\element-hq#8483](matrix-org/matrix-react-sdk#8483)). Fixes element-hq#9752 and element-hq#22108.
* Make date changes more obvious ([\element-hq#6410](matrix-org/matrix-react-sdk#6410)). Fixes element-hq#16221.
* Enable forwarding static locations ([\element-hq#8553](matrix-org/matrix-react-sdk#8553)).
* Log `TimelinePanel` debugging info when opening the bug report modal ([\element-hq#8502](matrix-org/matrix-react-sdk#8502)).
* Improve welcome screen, add opt-out analytics ([\element-hq#8474](matrix-org/matrix-react-sdk#8474)). Fixes element-hq#21946.
* Converting selected text to MD link when pasting a URL ([\element-hq#8242](matrix-org/matrix-react-sdk#8242)). Fixes element-hq#21634. Contributed by @Sinharitik589.
* Support Inter on custom themes ([\element-hq#8399](matrix-org/matrix-react-sdk#8399)). Fixes element-hq#16293.
* Add a `Copy link` button to the right-click message context-menu labs feature ([\element-hq#8527](matrix-org/matrix-react-sdk#8527)).
* Move widget screenshots labs flag to devtools ([\element-hq#8522](matrix-org/matrix-react-sdk#8522)).
* Remove some labs features which don't get used or create maintenance burden: custom status, multiple integration managers, and do not disturb ([\element-hq#8521](matrix-org/matrix-react-sdk#8521)).
* Add a way to toggle `ScrollPanel` and `TimelinePanel` debug logs ([\element-hq#8513](matrix-org/matrix-react-sdk#8513)).
* Spaces: remove blue beta dot ([\element-hq#8511](matrix-org/matrix-react-sdk#8511)). Fixes element-hq#22061.
* Order new search dialog results by recency ([\element-hq#8444](matrix-org/matrix-react-sdk#8444)).
* Improve pills ([\element-hq#6398](matrix-org/matrix-react-sdk#6398)). Fixes element-hq#16948 and element-hq#21281.
* Add a way to maximize/pin widget from the PiP view ([\element-hq#7672](matrix-org/matrix-react-sdk#7672)). Fixes element-hq#20723.
* Iterate video room designs in labs ([\element-hq#8499](matrix-org/matrix-react-sdk#8499)).
* Improve UI/UX in calls ([\element-hq#7791](matrix-org/matrix-react-sdk#7791)). Fixes element-hq#19937.
* Add ability to change audio and video devices during a call ([\element-hq#7173](matrix-org/matrix-react-sdk#7173)). Fixes element-hq#15595.
* Fix video rooms sometimes connecting muted when they shouldn't ([\element-hq#22125](element-hq#22125)).
* Avoid flashing the 'join conference' button at the user in video rooms ([\element-hq#22120](element-hq#22120)).
* Fully close Jitsi conferences on errors ([\element-hq#22060](element-hq#22060)).
* Fix click behavior of notification badges on spaces ([\element-hq#8627](matrix-org/matrix-react-sdk#8627)). Fixes element-hq#22241.
* Add missing return values in Read Receipt animation code ([\element-hq#8625](matrix-org/matrix-react-sdk#8625)). Fixes element-hq#22175.
* Fix 'continue' button not working after accepting identity server terms of service ([\element-hq#8619](matrix-org/matrix-react-sdk#8619)). Fixes element-hq#20003.
* Proactively fix stuck devices in video rooms ([\element-hq#8587](matrix-org/matrix-react-sdk#8587)). Fixes element-hq#22131.
* Fix position of the message action bar on left side bubbles ([\element-hq#8398](matrix-org/matrix-react-sdk#8398)). Fixes element-hq#21879. Contributed by @luixxiul.
* Fix edge case thread summaries around events without a msgtype ([\element-hq#8576](matrix-org/matrix-react-sdk#8576)).
* Fix favourites metaspace not updating ([\element-hq#8594](matrix-org/matrix-react-sdk#8594)). Fixes element-hq#22156.
* Stop spaces from displaying as rooms in new breadcrumbs ([\element-hq#8595](matrix-org/matrix-react-sdk#8595)). Fixes element-hq#22165.
* Fix avatar position of hidden event on ThreadView ([\element-hq#8592](matrix-org/matrix-react-sdk#8592)). Fixes element-hq#22199. Contributed by @luixxiul.
* Fix MessageTimestamp position next to redacted messages on IRC/modern layout ([\element-hq#8591](matrix-org/matrix-react-sdk#8591)). Fixes element-hq#22181. Contributed by @luixxiul.
* Fix padding of messages in threads ([\element-hq#8574](matrix-org/matrix-react-sdk#8574)). Contributed by @luixxiul.
* Enable overflow of hidden events content ([\element-hq#8585](matrix-org/matrix-react-sdk#8585)). Fixes element-hq#22187. Contributed by @luixxiul.
* Increase composer line height to avoid cutting off emoji ([\element-hq#8583](matrix-org/matrix-react-sdk#8583)). Fixes element-hq#22170.
* Don't consider threads for breaking continuation until actually created ([\element-hq#8581](matrix-org/matrix-react-sdk#8581)). Fixes element-hq#22164.
* Fix displaying hidden events on threads  ([\element-hq#8555](matrix-org/matrix-react-sdk#8555)). Fixes element-hq#22058. Contributed by @luixxiul.
* Fix button width and align 絵文字 (emoji) on the user panel ([\element-hq#8562](matrix-org/matrix-react-sdk#8562)). Fixes element-hq#22142. Contributed by @luixxiul.
* Standardise the margin for settings tabs ([\element-hq#7963](matrix-org/matrix-react-sdk#7963)). Fixes element-hq#20767. Contributed by @yuktea.
* Fix room history not being visible even if we have historical keys ([\element-hq#8563](matrix-org/matrix-react-sdk#8563)). Fixes element-hq#16983.
* Fix oblong avatars in video room lobbies ([\element-hq#8565](matrix-org/matrix-react-sdk#8565)).
* Update thread summary when latest event gets decrypted ([\element-hq#8564](matrix-org/matrix-react-sdk#8564)). Fixes element-hq#22151.
* Fix codepath which can wrongly cause automatic space switch from all rooms ([\element-hq#8560](matrix-org/matrix-react-sdk#8560)). Fixes element-hq#21373.
* Fix effect of URL preview toggle not updating live ([\element-hq#8561](matrix-org/matrix-react-sdk#8561)). Fixes element-hq#22148.
* Fix visual bugs on AccessSecretStorageDialog ([\element-hq#8160](matrix-org/matrix-react-sdk#8160)). Fixes element-hq#19426. Contributed by @luixxiul.
* Fix the width bounce of the clock on the AudioPlayer ([\element-hq#8320](matrix-org/matrix-react-sdk#8320)). Fixes element-hq#21788. Contributed by @luixxiul.
* Hide the verification left stroke only on the thread list ([\element-hq#8525](matrix-org/matrix-react-sdk#8525)). Fixes element-hq#22132. Contributed by @luixxiul.
* Hide recently_viewed dropdown when other modal opens ([\element-hq#8538](matrix-org/matrix-react-sdk#8538)). Contributed by @yaya-usman.
* Only jump to date after pressing the 'go' button ([\element-hq#8548](matrix-org/matrix-react-sdk#8548)). Fixes element-hq#20799.
* Fix download button not working on events that were decrypted too late ([\element-hq#8556](matrix-org/matrix-react-sdk#8556)). Fixes element-hq#19427.
* Align thread summary button with bubble messages on the left side ([\element-hq#8388](matrix-org/matrix-react-sdk#8388)). Fixes element-hq#21873. Contributed by @luixxiul.
* Fix unresponsive notification toggles ([\element-hq#8549](matrix-org/matrix-react-sdk#8549)). Fixes element-hq#22109.
* Set color-scheme property in themes ([\element-hq#8547](matrix-org/matrix-react-sdk#8547)). Fixes element-hq#22124.
* Improve the styling of error messages during search initialization. ([\element-hq#6899](matrix-org/matrix-react-sdk#6899)). Fixes element-hq#19245 and element-hq#18164. Contributed by @KalleStruik.
* Don't leave button tooltips open when closing modals ([\element-hq#8546](matrix-org/matrix-react-sdk#8546)). Fixes element-hq#22121.
* update matrix-analytics-events ([\element-hq#8543](matrix-org/matrix-react-sdk#8543)).
* Handle Jitsi Meet crashes more gracefully ([\element-hq#8541](matrix-org/matrix-react-sdk#8541)).
* Fix regression around pasting links ([\element-hq#8537](matrix-org/matrix-react-sdk#8537)). Fixes element-hq#22117.
* Fixes suggested room not ellipsized on shrinking ([\element-hq#8536](matrix-org/matrix-react-sdk#8536)). Contributed by @yaya-usman.
* Add global spacing between display name and location body ([\element-hq#8523](matrix-org/matrix-react-sdk#8523)). Fixes element-hq#22111. Contributed by @luixxiul.
* Add box-shadow to the reply preview on the main (left) panel only ([\element-hq#8397](matrix-org/matrix-react-sdk#8397)). Fixes element-hq#21894. Contributed by @luixxiul.
* Set line-height: 1 to RedactedBody inside GenericEventListSummary for IRC/modern layout ([\element-hq#8529](matrix-org/matrix-react-sdk#8529)). Fixes element-hq#22112. Contributed by @luixxiul.
* Fix position of timestamp on the chat panel in IRC layout and message edits history modal window ([\element-hq#8464](matrix-org/matrix-react-sdk#8464)). Fixes element-hq#22011 and element-hq#22014. Contributed by @luixxiul.
* Fix unexpected and inconsistent inheritance of line-height property for mx_TextualEvent ([\element-hq#8485](matrix-org/matrix-react-sdk#8485)). Fixes element-hq#22041. Contributed by @luixxiul.
* Set the same margin to the right side of NewRoomIntro on TimelineCard ([\element-hq#8453](matrix-org/matrix-react-sdk#8453)). Contributed by @luixxiul.
* Remove duplicate tooltip from user pills ([\element-hq#8512](matrix-org/matrix-react-sdk#8512)).
* Set max-width for MLocationBody and MLocationBody_map by default ([\element-hq#8519](matrix-org/matrix-react-sdk#8519)). Fixes element-hq#21983. Contributed by @luixxiul.
* Simplify ReplyPreview UI implementation ([\element-hq#8516](matrix-org/matrix-react-sdk#8516)). Fixes element-hq#22091. Contributed by @luixxiul.
* Fix thread summary overflow on narrow message panel on bubble message layout ([\element-hq#8520](matrix-org/matrix-react-sdk#8520)). Fixes element-hq#22097. Contributed by @luixxiul.
* Live location sharing - refresh beacon timers on tab becoming active ([\element-hq#8515](matrix-org/matrix-react-sdk#8515)).
* Enlarge emoji again ([\element-hq#8509](matrix-org/matrix-react-sdk#8509)). Fixes element-hq#22086.
* Order receipts with the most recent on the right ([\element-hq#8506](matrix-org/matrix-react-sdk#8506)). Fixes element-hq#22044.
* Disconnect from video rooms when leaving ([\element-hq#8500](matrix-org/matrix-react-sdk#8500)).
* Fix soft crash around threads when room isn't yet in store ([\element-hq#8496](matrix-org/matrix-react-sdk#8496)). Fixes element-hq#22047.
* Fix reading of cached room device setting values ([\element-hq#8491](matrix-org/matrix-react-sdk#8491)).
* Add loading spinners to threads panels ([\element-hq#8490](matrix-org/matrix-react-sdk#8490)). Fixes element-hq#21335.
* Fix forwarding UI papercuts ([\element-hq#8482](matrix-org/matrix-react-sdk#8482)). Fixes element-hq#17616.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Pills A-Themes-Official Official themes (light, dark) A-Theming P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests