This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Display a warning if a third party invite for a room was sent to an address that is not bound publicly to our account #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the invited email through to RoomPreviewBar, display it in a temporary way currently. Remove a condition from RoomView render that appears to be functionally identical to the previous.
… warn if it doesn't match our account.
| @@ -539,10 +539,14 @@ module.exports = React.createClass({ | |||
| // | |||
| // eventId is optional and will cause a switch to the context of that | |||
| // particular event. | |||
| // @param {Object} thirdPartyInvite Object containing data about the third party | |||
| // we received to join the room, if any. | |||
| // @param {Object} thirdPartyInvite.inviteSignUrl 3pid invite sign URL | |||
There was a problem hiding this comment.
s/Object/string/ here and below?
|
Hrm. It doesn't make RoomPreviewBar any less of a mess. Looks ok other than the minor comments given though |
dbkr
added a commit
that referenced
this pull request
Mar 18, 2016
Display a warning if a third party invite for a room was sent to an address that is not bound publicly to our account
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#924
Requires matrix-org/matrix-js-sdk#113
Could use styling magic from @ara4n