Add a method to the js sdk to look up 3pids on the ID server. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {string} medium The medium of the threepid, eg. 'email' | ||
| * @param {string} address The textual address of the threepid | ||
| * @param {module:client.callback} callback Optional. | ||
| * @return {module:client.Promise} Resolves: TODO |
There was a problem hiding this comment.
aside: y'know, just because we've been rubbish at documenting these so far doesn't mean that we can't start...
|
lgtm |
dbkr
added a commit
that referenced
this pull request
Mar 18, 2016
Add a method to the js sdk to look up 3pids on the ID server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also moves the manual json decoding for the ID server into the common ID server block, since we'll have to do it for all ID server requests, rather than doing it in requestEmailToken.