Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Suppress CORS errors in the 'failed to join room' dialog #2306

Merged
merged 3 commits into from
Dec 5, 2018

Conversation

turt2live
Copy link
Member

This isn't pretty, but it does address element-hq/element-web#7526

Tested with Chrome and Firefox to ensure the message is stable enough to parse.

This isn't pretty, but it does address element-hq/element-web#7526

Tested with Chrome and Firefox to ensure the message is stable enough to parse.
@turt2live turt2live requested a review from a team November 27, 2018 21:24
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the problem here that we are taking err.message and plonking it into the UI?

If we do need to do this kind of hack, please make sure it's flagged with a big XXX comment.

@turt2live
Copy link
Member Author

The annoying part is that err.message does have valid strings in it most of the time. Some of which are actually generated within riot and not direct from the server.

Will flag this as a disgusting hack though.

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK yeah - sounds like this is a quick fix for a symptom of a deeper problem. Thanks for XXXing & opening element-hq/element-web#7785 - it's a smell if we have to write hacks like this to work around bugs in our own library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants