Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS error popup when failing to join room #4541

Closed
uhoreg opened this issue Jul 8, 2017 · 8 comments
Closed

CORS error popup when failing to join room #4541

uhoreg opened this issue Jul 8, 2017 · 8 comments
Labels
P1 S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@uhoreg
Copy link
Member

uhoreg commented Jul 8, 2017

According to erdnaxeli in the discussion starting at https://matrix.to/#/!cURbafjkfsMDVwdRDQ:matrix.org/$1499518666138684TsxJg:cervoi.se, failing to join a room caused a popup to display a CORS error. @ara4n had previously fixed all the error popups to be more friendly, but either he missed one, or a new one crept in.
@erdnaxeli
Copy link

2017-07-08-152703_1254x1041_scrot

@MTRNord
Copy link
Contributor

MTRNord commented Jul 8, 2017 •
edited
Loading

Got the same error right now on /develop (room #matrix:matrix.org)

@MTRNord
Copy link
Contributor

MTRNord commented Jul 8, 2017

My error is HTTP error 504

@lampholder
Copy link
Member

Dunno what the underlying error is, but we should never be vomiting up that kind of error message direct to the user :\

@uhoreg
Copy link
Member Author

uhoreg commented Sep 14, 2017

Apparently, we also get the CORS error popup when it fails to change settings, as per https://matrix.to/#/!cURbafjkfsMDVwdRDQ:matrix.org/$1505422396418vKhhA:matrix.freelock.com

This was referenced Oct 23, 2017
Closed
Closed
@grahamperrin grahamperrin mentioned this issue Nov 5, 2017
Closed
@grahamperrin
Copy link

FWIW I haven't seen any token, within an error dialogue, recently.

@aaronraimist
Copy link
Collaborator

Fixed by
matrix-org/matrix-react-sdk#2306

See
#7526 (comment)

@turt2live
Copy link
Member

Closing in favour of #7785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@grahamperrin @erdnaxeli @uhoreg @turt2live @MTRNord @lampholder @aaronraimist