MSC3083: Add additional tests for joining over federation. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Apr 8, 2021
|
This will also need the changes in matrix-org/synapse#9868 so that the returned error code is correct over federation. |
|
This seems to be failing since the latest Docker tag for Synapse doesn't have the required functionality (it will be in Synapse 1.33.0 which should RC this week). I don't think there's much to do to get CI to pass besides just wait for the tag to update? |
|
There's a new latest image, so hopefully this will pass now. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #98 to add tests for matrix-org/synapse#9800.
The tests are pretty much the same, as #98, but the users are no longer on the same server.