Test MSC3083 - joining a restricted room. #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kegsay
approved these changes
Apr 7, 2021
|
|
||
| // Leaving the room works and the user is unable to re-join. | ||
| bob.LeaveRoom(t, room) | ||
| bob.LeaveRoom(t, space) |
There was a problem hiding this comment.
What happens if you leave the space first?
There was a problem hiding this comment.
Leaving the space first should be fine. The ordering of these two steps doesn't matter.
Co-authored-by: Kegsay <kegan@matrix.org>
|
Although...I now realize that these tests aren't actually running due to matrix-org/pipelines#139, although they won't run anyway until Synapse opts into them. Seems like a chicken-and-egg problem to me. 😢 |
This was referenced Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests matrix-org/synapse#9735 by creating a room that requires membership of a space to join, then attempts to join it (which will fail), then joins the space, then joins the room (which now succeeds).
See #93 for why this is being re-created.