Skip to content

Commit

Permalink
Links to issue with more info on flaky behavior
Browse files Browse the repository at this point in the history
- file watcher on non windows has large impact on start time

Closes dotnet#33992
  • Loading branch information
maryamariyan committed Nov 3, 2022
1 parent 22de912 commit d3dca19
Showing 1 changed file with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ public void OnLoadErrorCanIgnoreErrors()
}

[Fact]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
public void CanSetValuesAndReloadValues()
{
WriteTestFiles();
Expand Down Expand Up @@ -508,7 +508,7 @@ public void CanSetValuesAndReloadValues()
}

[Fact]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
public async Task ReloadOnChangeWorksAfterError()
{
_fileSystem.WriteFile("reload.json", @"{""JsonKey1"": ""JsonValue1""}");
Expand Down Expand Up @@ -539,7 +539,7 @@ await WaitForChange(
}

[Fact]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
public async Task TouchingFileWillReload()
{
_fileSystem.WriteFile("reload.json", @"{""JsonKey1"": ""JsonValue1""}");
Expand Down Expand Up @@ -576,7 +576,7 @@ await WaitForChange(
}

[Fact]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
public async Task CreatingOptionalFileInNonExistentDirectoryWillReload()
{
var directory = Path.GetRandomFileName();
Expand Down Expand Up @@ -610,7 +610,7 @@ await WaitForChange(
}

[Theory]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
[InlineData(false)]
[InlineData(true)]
public async Task DeletingFilesThatRedefineKeysWithReload(bool optional)
Expand Down Expand Up @@ -691,7 +691,7 @@ await WaitForChange(
}

[Theory]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
[InlineData(false)]
[InlineData(true)]
public async Task DeletingFileWillReload(bool optional)
Expand Down Expand Up @@ -730,7 +730,7 @@ await WaitForChange(
}

[Fact]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
public async Task CreatingWritingDeletingCreatingFileWillReload()
{
var config = CreateBuilder()
Expand Down Expand Up @@ -910,7 +910,7 @@ public void CanEnumerateProviders()
}

[Fact]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
public async Task TouchingFileWillReloadForUserSecrets()
{
string userSecretsId = "Test";
Expand Down

0 comments on commit d3dca19

Please sign in to comment.