Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep track of select flaky functional tests for Microsoft.Extensions.Configuration #33992

Closed
1 task
maryamariyan opened this issue Mar 24, 2020 · 1 comment · Fixed by #77859
Closed
1 task

Keep track of select flaky functional tests for Microsoft.Extensions.Configuration #33992

maryamariyan opened this issue Mar 24, 2020 · 1 comment · Fixed by #77859
Labels
area-Extensions-Configuration in-pr There is an active PR which will close this issue when it is merged
Milestone
Future

Comments

@maryamariyan
Copy link
Member

maryamariyan commented Mar 24, 2020 •
edited
Loading

In extensions repo, Flaky attribute is used on these tests:
https://github.com/dotnet/extensions/blob/master/src/Configuration/test/Config.FunctionalTests/ConfigurationTests.cs#L468

but I'll be using ActiveIssue instead and this issue is tracking them so we add back coverage later.

  • Check if there is an underlying product bug or a test bug, and re-enable
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Mar 24, 2020
@maryamariyan maryamariyan added this to the Future milestone Jul 1, 2020
@maryamariyan maryamariyan removed the untriaged New issue has not been triaged by the area owner label Jul 1, 2020
@maryamariyan
Copy link
Member Author

We can close this issue in favor of #42036. Seems like the test flakiness is because of file watcher behaviour in non-windows platform.

Before closing this, we should set the issue number on the ActiveIssue to the other issue number.

maryamariyan added a commit to maryamariyan/runtime that referenced this issue Nov 3, 2022
@maryamariyan
Links to issue with more info on flaky behavior
d3dca19 
- file watcher on non windows has large impact on start time

Closes dotnet#33992
@maryamariyan maryamariyan mentioned this issue Nov 3, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Extensions-Configuration in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Links to issue with more info on flaky behavior maryamariyan/runtime
2 participants
@maryamariyan @Dotnet-GitSync-Bot