make ensure check file hash #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #205 this is a breaking change because since everyone running `bin ensure` after this gets merged will result in all their binaries getting re-downloaded. This is good though since that will fix all the incorrect hashes that are wrong in the first place. I've decided not to add a flag to skip this check since checking hashes is the right thing to do in the first place. Signed-off-by: Marcos Lilljedahl <marcosnils@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #205
this is a breaking change because since everyone running
bin ensureafter this gets merged will result in all their binaries getting
re-downloaded. This is good though since that will fix all the incorrect
hashes that are wrong in the first place.
I've decided not to add a flag to skip this check since checking hashes
is the right thing to do in the first place.
Signed-off-by: Marcos Lilljedahl marcosnils@gmail.com